Fix logic on warning for ogre versions different than 1.9.x #465
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #465 +/- ##
===============================================
Coverage 53.35% 53.35%
===============================================
Files 131 131
Lines 12035 12035
===============================================
Hits 6421 6421
Misses 5614 5614 Continue to review full report at Codecov.
|
|
As expected, the warning is present in the Windows build https://build.osrfoundation.org/job/ign_rendering-pr-win/2185/consoleText |
CMakeLists.txt
Outdated
|
|
||
| if (OGRE_FOUND) | ||
| IGN_BUILD_WARNING("Ogre 1.x versions greater than 1.9 are not officially supported." | ||
| if ((${OGRE_VERSION} VERSION_LESS 1.9.0) OR (${OGRE_VERSION} VERSION_GREATER_EQUAL 1.10.0)) |
There was a problem hiding this comment.
If the find package call above ever going to find something less than 1.9?
There was a problem hiding this comment.
eeeeeek no. Changed in ad0b350
…ill skip them Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
* ogre: Do not assume that ogre plugins have lib prefix on macOS (#454) Signed-off-by: Silvio <silvio@traversaro.it> * Fix compilation against Ogre 1.10.12 (#390) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Avoid symbol redefition to fix armel builds (#457) * Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Fix logic on warning for ogre versions different than 1.9.x (#465) * Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Fix context attributes of glXCreateContextAttribsARB. (#460) Signed-off-by: Hill Ma <hillma@google.com> Co-authored-by: Silvio Traversaro <silvio@traversaro.it> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Hill Ma <mahiuchun@users.noreply.github.com>
…m#465) * Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
…m#465) * Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
The warning drama saga continues here, after @traversaro suggestion #453 (comment) . Let's see if I can this right now.