Skip to content

Conversation

@bboure
Copy link
Contributor

@bboure bboure commented Jun 25, 2017

Changed

  • Used path_info() instead of explode() to parse filename and extensions.

Added

  • wildcard for mime types. e.g.: image/* will match image/png

Fixed

  • the codestyle to be PSR-2 compliant.
  • too big/small error messages

bboure added 2 commits June 25, 2017 18:19
- Enable mime type wildcards
- Fix too big/small error messages
- Fix `UploadFromUrl::extendOptions`
@codecov-io
Copy link

codecov-io commented Jun 25, 2017

Codecov Report

Merging #7 into master will increase coverage by 0.69%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   82.97%   83.67%   +0.69%     
==========================================
  Files           2        2              
  Lines          47       49       +2     
==========================================
+ Hits           39       41       +2     
  Misses          8        8
Impacted Files Coverage Δ
tests/models/Model.php 0% <ø> (ø) ⬆️
src/UploadFromUrl.php 91.11% <94.73%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b6efe...663c0c2. Read the comment docs.

@igogo5yo igogo5yo merged commit e4023f3 into igogo5yo:master Jun 26, 2017
@igogo5yo
Copy link
Owner

@bboure thank you for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants