Igor Serebryany
igor47

Organizations

@Moomers
Aug 9, 2016
igor47 opened pull request airbnb/synapse#207
@igor47
[base watcher] filter on set_backends
1 commit with 42 additions and 36 deletions
igor47 created branch filter_on_set at airbnb/synapse
Aug 9, 2016
Aug 8, 2016
igor47 commented on commit airbnb/nerve@cc89f99be3
@igor47

that paramater is passed straight to Net::HTTP here: https://github.com/airbnb/nerve/blob/master/lib/nerve/service_watcher/http.rb#L53 . this means…

Aug 3, 2016
igor47 commented on pull request airbnb/synapse#206
@igor47

should we push out a new version?

Aug 3, 2016
igor47 commented on pull request airbnb/synapse#206
@igor47

something like "synapse: node #{id} disappeared before it could be read" is probably fine, along with a comment in the code explaining why this cou…

Aug 3, 2016
igor47 commented on pull request airbnb/synapse#206
@igor47

looks good, i left one nit about the wording of the log message.

Aug 3, 2016
igor47 commented on pull request airbnb/synapse#206
@igor47

i guess the idea here is that we found the node in the list, but then it disappeared before we could read it's contents. so, we will omit it from n…

Aug 3, 2016
igor47 commented on issue airbnb/synapse#205
@igor47

we use state_file_path, and this helps quite a bit. the only case where we restart today is when synapse restarts and when we have to add an entire…

Aug 3, 2016
igor47 commented on issue airbnb/synapse#205
@igor47

i guess what would happen is synapse would bail and restart. this would force a restart of haproxy which might cause some instability. we've certai…

igor47 created tag v0.10.1 at airbnb/stemcell
Jul 28, 2016
Jul 28, 2016
@igor47
  • @igor47 61f54ed
    [launcher] check for nil classic link
igor47 created tag v0.10.0 at airbnb/stemcell
Jul 28, 2016
Jul 28, 2016
@igor47
  • @igor47 da15775
    [stemcell] bump version to v0.10.0
Jul 28, 2016
@igor47
Jul 28, 2016
igor47 merged pull request airbnb/stemcell#73
@igor47
Additional options
15 commits with 217 additions and 68 deletions
Jul 28, 2016
@igor47
  • @igor47 a5846c4
    [travis] update formatter and ruby versions
Jul 27, 2016
igor47 commented on pull request airbnb/stemcell#73
@igor47

okay, addressed all feedback, PTAL?

Jul 27, 2016
@igor47
Jul 27, 2016
igor47 commented on pull request airbnb/stemcell#73
@igor47

will do

Jul 27, 2016
igor47 commented on pull request airbnb/stemcell#73
@igor47

good catch

Jul 27, 2016
igor47 commented on pull request airbnb/stemcell#71
@igor47

we only ever set @aws_access_key and @aws_secret_key in a loop above, where we go through REQUIRED_OPTIONS and call instance_variable_set. now that…

Jul 27, 2016
igor47 commented on pull request airbnb/stemcell#73
@igor47

ok, this PR is ready now -- @jtai can you take another look? i had to refactor the classic link settings because instances must be running before c…

Jul 27, 2016
@igor47
  • @igor47 61bf05a
    [OptionParser] make assignment easier to read
Jul 27, 2016
@igor47
Jul 27, 2016
igor47 commented on pull request rspec/rspec-mocks#1104
@igor47

good point!

Jul 27, 2016
igor47 commented on pull request rspec/rspec-mocks#1104
@igor47

I have a use case for temporarily supressing all verification -- the AWS_SDK gem. the clients in these gems (both v1 and v2) do not actually define…

Jul 27, 2016
@igor47
Jul 27, 2016
@igor47
  • @igor47 00f13de
    [launcher] fix missing function in wait
Jul 27, 2016
@igor47
Jul 27, 2016
@igor47
  • @igor47 4a22a7e
    [option_parser] don't clobber vpc settings