docs(changeset): Handle null values in Sourced fields

igorkamyshev · Nov 17, 2022 · 072aae1 · 072aae1
1 parent 3419015
commit 072aae1
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 2 deletions.
diff --git a/.changeset/few-bags-report.md b/.changeset/few-bags-report.md
@@ -0,0 +1,5 @@
+---
+'@farfetched/core': patch
+---
+
+Handle null values in Sourced fields
diff --git a/packages/core/src/misc/__tests__/sourced.spec.ts b/packages/core/src/misc/__tests__/sourced.spec.ts
@@ -32,6 +32,18 @@ describe('normalizeSourced (with clock)', () => {
     expect(scope.getState($normalized)).toBe(false);
   });
 
+  test('handle null value', async () => {
+    const clock = createEvent();
+
+    const $normalized = normalizeSourced({ field: null, clock });
+
+    const scope = fork();
+
+    await allSettled(clock, { scope });
+
+    expect(scope.getState($normalized)).toBe(null);
+  });
+
   test('handle store value', async () => {
     const clock = createEvent();
 
@@ -132,6 +144,18 @@ describe('normalizeSourced (with source)', () => {
     expect(scope.getState($normalized)).toBe(false);
   });
 
+  test('handle null value', async () => {
+    const source = createStore(null);
+
+    const $normalized = normalizeSourced({ field: null, source });
+
+    const scope = fork();
+
+    await allSettled(source, { scope, params: 12 });
+
+    expect(scope.getState($normalized)).toBe(null);
+  });
+
   test('handle store value', async () => {
     const $source = createStore('');
 

diff --git a/packages/core/src/misc/sourced.ts b/packages/core/src/misc/sourced.ts
@@ -43,7 +43,7 @@ function normalizeSourced<Data, Result, Source>({
       const $storeField = field as Store<Result>;
 
       sample({ clock, source: $storeField, target: $target });
-    } else if (field.source && field.fn) {
+    } else if (field?.source && field?.fn) {
       const callbackField = field as CallbackWithSource<Data, Result, Source>;
 
       sample({
@@ -71,7 +71,7 @@ function normalizeSourced<Data, Result, Source>({
       const $storeField = field as Store<Result>;
 
       $target = $storeField;
-    } else if (field.source && field.fn) {
+    } else if (field?.source && field?.fn) {
       const callbackField = field as CallbackWithSource<Data, Result, Source>;
 
       $target = combine($source, callbackField.source, callbackField.fn);