Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cannot find module 'rc' error when use npx #210

Merged
merged 1 commit into from Jul 23, 2021

Conversation

shhdgit
Copy link
Contributor

@shhdgit shhdgit commented Jul 23, 2021

After the v0.28.0 release, there's an error when using npx.

npx markdownlint-cli ...

error:

node:internal/modules/cjs/loader:930
  throw err;
  ^

Error: Cannot find module 'rc'

@shhdgit shhdgit changed the title fix: Cannot find module 'rc' error when use npx Fix Cannot find module 'rc' error when use npx Jul 23, 2021
@DavidAnson
Copy link
Collaborator

@DavidAnson DavidAnson commented Jul 23, 2021

Thanks - I'll release an update in a moment. I want to make sure I know why this didn't break tests. (Presumably some devDependency includes rc?)

@DavidAnson
Copy link
Collaborator

@DavidAnson DavidAnson commented Jul 23, 2021

Yup:

markdownlint-cli % npm ls rc
markdownlint-cli@0.28.0
└─┬ ava@3.15.0
  └─┬ update-notifier@5.0.1
    └─┬ latest-version@5.1.0
      └─┬ package-json@6.5.0
        ├─┬ registry-auth-token@4.1.1
        │ └── rc@1.2.8
        └─┬ registry-url@5.1.0
          └── rc@1.2.8 deduped

@DavidAnson
Copy link
Collaborator

@DavidAnson DavidAnson commented Jul 23, 2021

Sorry, I should have noticed the mistake in the PR.

@DavidAnson DavidAnson merged commit 8fd56fb into igorshubovych:master Jul 23, 2021
12 checks passed
@DavidAnson
Copy link
Collaborator

@DavidAnson DavidAnson commented Jul 23, 2021

Thanks again, I've published 0.28.1 just now.

@DavidAnson
Copy link
Collaborator

@DavidAnson DavidAnson commented Jul 23, 2021

@flcdrg, just FYI, I wrote this GitHub action to use markdownlint-cli2: https://github.com/DavidAnson/markdownlint-cli2-action. It may be faster. And you may not like the approach I took. ;)

@flcdrg
Copy link

@flcdrg flcdrg commented Jul 23, 2021

@DavidAnson thanks.. I reckon I used something similar with AzDO Pipelines ages ago. Will take a look 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants