Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Apr 6, 2012
  1. @fabpot

    merged branch brikou/patch-3 (PR #309)

    fabpot authored
    Commits
    -------
    
    cc69fa9 fixed missing space
    
    Discussion
    ----------
    
    fixed missing space
  2. @fabpot

    merged branch jstout24/master (PR #310)

    fabpot authored
    Commits
    -------
    
    d73abb9 added JMSDiExtraBundle to readme
    
    Discussion
    ----------
    
    added JMSDiExtraBundle to readme
    
    This still needs documentation
    
    I see that it's located http://jmsyst.com/bundles/JMSDiExtraBundle and should be ported to Symfony.com's docs.
  3. @fabpot

    merged branch Tobion/requirements-refactor (PR #258)

    fabpot authored
    Commits
    -------
    
    4632103 added RequirementCollection
    f7c1316 added specialized PhpIniRequirement class
    cbaf855 added upstream requirements
    0e56f19 replace __DIR__ with dirname(__FILE__) for PHP<5.3
    d4e0efe short ternary operator not available in PHP 5.2 and language adjustments
    aa0da83 reduce help duplication by inferring text from html version
    163aa49 made requirements check compatible with PHP 5.2
    46e8e5a refactor Symfony requirements
    
    Discussion
    ----------
    
    Refactor Symfony requirements
    
    The requirements checks were duplicated for the web-based `web/config.php` and console-based `app/check.php` scripts. So I refactored the symfony requirements to its own class that is easier to modify and reuse. Feel free to make suggestions.
    
    Both scripts behave as before, just some cosmetic changes in the output.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-02-04T20:49:30Z
    
    @fabpot all ready now
    
    ---------------------------------------------------------------------------
    
    by brikou at 2012-03-16T08:10:27Z
    
    this addition would be even greater if a cookbook was written explaining how to extend this requirement check in order to add custom requirements (for example checking that php gd extension is installed for a custom project)
    
    ;)
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-03-31T14:36:50Z
    
    @vicb @fabpot ping
    I rebased and added a `RequirementCollection`. That allows a custom project to specify it's own requirements (subclasssing `RequirementCollection`) and then optionally merging the Symfony requirements (`RequirementCollection->addCollection()`).
    Naming is inspired by `RouteCollection`.
    
    ---------------------------------------------------------------------------
    
    by brikou at 2012-03-31T14:58:14Z
    
    @Tobion looks great ;)
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-06T01:01:19Z
    
    Can it be merged? I don't want to rebase again. Are there any objections?
Commits on Apr 4, 2012
  1. @j

    added JMSDiExtraBundle to readme

    j authored
Commits on Apr 2, 2012
  1. @brikou

    fixed missing space

    brikou authored
Commits on Mar 31, 2012
  1. @Tobion

    added RequirementCollection

    Tobion authored
  2. @Tobion
Commits on Mar 29, 2012
  1. @Tobion

    added upstream requirements

    Tobion authored
  2. @havvg @Tobion

    replace __DIR__ with dirname(__FILE__) for PHP<5.3

    havvg authored Tobion committed
  3. @Tobion
  4. @Tobion
  5. @Tobion
  6. @Tobion

    refactor Symfony requirements

    Tobion authored
Commits on Mar 23, 2012
  1. @fabpot

    merged branch igorw/parameters-indentation (PR #300)

    fabpot authored
    Commits
    -------
    
    9c74db8 Change parameters.yml indentation to 4 spaces
    
    Discussion
    ----------
    
    Change parameters.yml indentation to 4 spaces
    
    This is consistent with the other `.yml` files in `app/config`.
Commits on Mar 20, 2012
Commits on Mar 19, 2012
  1. @fabpot

    removed obsolete bin directory

    fabpot authored
Commits on Mar 18, 2012
  1. @fabpot

    updated dependencies

    fabpot authored
  2. @fabpot

    updated dependencies

    fabpot authored
  3. @fabpot

    merged branch Seldaek/diextra (PR #275)

    fabpot authored
    Commits
    -------
    
    e8f0210 Switch to 1.0.1 tag of di-extra-bundle
    65a5403 Add DiExtra and complete updating SecurityExtra
    
    Discussion
    ----------
    
    Add DiExtra and complete updating SecurityExtra
    
    Closes #252 /cc @schmittjoh would be nice to have a new tag for jms/di-extra-bundle - the 1.0.0 is broken since metadata moved to the jms vendor.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2012-02-27T17:26:04Z
    
    Also #252 mentionned this issue sensiolabs/SensioFrameworkExtraBundle#84 I don't know what needs to be done exactly but please give it some attention.
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-02-27T18:14:37Z
    
    I can tag another version of DiExtra later today.
    
    The SensioFrameworkExtraBundle PR depends on whether the bundle needs to support both 2.0 and 2.1. If so, it needs to be fixed in SensioFrameworkExtraBundle otherwise, I can fix it inside JMSDiExtraBundle. Ideally though, we would just add a ClassUtils class to the HttpKernel component and use that, just like Doctrine Common has one as well.
    
    One question regarding the access_control, you removed my changes there. Any reason for that?
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-02-28T05:04:08Z
    
    I've created a 1.0.1 tag with a fixed composer file.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2012-02-28T08:17:09Z
    
    Ok, I updated to use it, as for the access_control changes, I just didn't pull them in because they didn't seem to add any direct value. I mean that they add a dependency on your bundle for no particular reason in the default config, so it makes it harder for people to remove your bundle if they want to, and it also adds non-standard stuff to the default config, which you won't be able to find in the official docs AFAIK. If this is mistaken, let me know and I can add it.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2012-02-28T08:20:32Z
    
    @fabpot can you look into @schmittjoh's comment above regarding the SensioFrameworkExtraBundle PR?
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-02-28T12:50:15Z
    
    It was not functionally equivalent to what is in the config right now. I have seen a lot of people asking to only allow anonymous users to the login page (not already logged in users). The current config does not do this. The updated config did.
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-03-18T18:21:39Z
    
    @fabpot @vicb can you look on this and merge the PRs in order to get this fixed?
    
    It's security related and imho this should be fixed sooner rather that later...
Commits on Mar 11, 2012
  1. @fabpot

    merged branch cedriclombardot/patch-1 (PR #290)

    fabpot authored
    Commits
    -------
    
    cfc3abc Ignore the composer.phar
    
    Discussion
    ----------
    
    Ignore the composer.phar
    
    Just ignore the `composer.phar` file should be getted running :
    
    ````
    wget http://getcomposer.org/composer.phar
    ````
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-03-08T18:35:22Z
    
    Composer is probably something you will have to install globally on your machine, not locally in your project. So, I'm -1 on this change as this is temporary.
    
    ---------------------------------------------------------------------------
    
    by cedriclombardot at 2012-03-08T21:26:44Z
    
    If we read some installation docs for bundles or libs, people take the last version of the composer into their projects so i think that doesn't cost so cheap to prenvent a local installation ingoring this file
  2. @fabpot

    merged branch jmfontaine/master (PR #292)

    fabpot authored
    Commits
    -------
    
    043eccc Fixed a typo for consistency
    9dc4d47 Added removal of "web/bundles/acmedemo" directory advice
    1d55a29 Changed order of steps in README.md to be consistent with app/check.php messages
    
    Discussion
    ----------
    
    Fixed some inconsistencies in README.md file
Commits on Mar 10, 2012
  1. @jmfontaine
  2. @jmfontaine
Commits on Mar 8, 2012
  1. @jmfontaine

    Changed order of steps in README.md to be consistent with app/check.p…

    jmfontaine authored
    …hp messages
    
    Installing vendors is step b while app/check.php which is step a reads "[[ ERROR ]] Checking that vendor libraries are installed: FAILED […] You must fix this problem before resuming the check."
  2. @fabpot

    merged branch brikou/patch-2 (PR #291)

    fabpot authored
    Commits
    -------
    
    6abab28 updated assetic'es filter paths to be the same as the one used in cookbook's entries
    
    Discussion
    ----------
    
    updated assetic'es filter paths to be the same as the one used in cookbo...
    
    ...ok's entries
  3. @brikou
Commits on Mar 7, 2012
  1. @cedriclombardot
Commits on Mar 3, 2012
  1. @fabpot

    merged branch ajessu/composer-vendors (PR #286)

    fabpot authored
    Commits
    -------
    
    3818947 Change vendor notices to use composer
    
    Discussion
    ----------
    
    Change missing vendor notices to use composer
    
    I linked to the composer home.
    Not sure if the links should point to the composer download page: http://getcomposer.org/download  for even easier instructions.
  2. @ajessu
Commits on Mar 2, 2012
  1. @fabpot

    merged branch janpieper/patch-1 (PR #284)

    fabpot authored
    Commits
    -------
    
    cac0d2b stripos() does not return TRUE if needle was found in haystack
    
    Discussion
    ----------
    
    stripos() does not return TRUE if needle was found in haystack
    
    > Returns the position of where the needle exists relative to the beginnning of the haystack string (independent of offset).
    
    http://docs.php.net/manual/en/function.stripos.php
  2. @janpieper
  3. @fabpot
  4. @fabpot

    merged 2.0

    fabpot authored
  5. @fabpot

    revert README tweaks :(

    fabpot authored
  6. @fabpot

    merged 2.0

    fabpot authored
Something went wrong with that request. Please try again.