Extract interface for storage

igorw · Jan 6, 2013 · 0937d1f · 0937d1f
1 parent a7d7325
commit 0937d1f
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 23 deletions.
diff --git a/src/Igorw/Trashbin/Provider.php b/src/Igorw/Trashbin/Provider.php
@@ -23,7 +23,7 @@ public function register(Application $app)
         });
 
         $app['app.storage'] = $app->share(function ($app) {
-            return new Storage($app['predis']);
+            return new RedisStorage($app['predis']);
         });
 
         $app['app.validator'] = $app->share(function () {

diff --git a/src/Igorw/Trashbin/RedisStorage.php b/src/Igorw/Trashbin/RedisStorage.php
@@ -0,0 +1,25 @@
+<?php
+
+namespace Igorw\Trashbin;
+
+use Predis\Client;
+
+class RedisStorage implements Storage
+{
+    private $redis;
+
+    public function __construct(Client $redis)
+    {
+        $this->redis = $redis;
+    }
+
+    public function get($id)
+    {
+        return $this->redis->hgetall($id);
+    }
+
+    public function set($id, array $data)
+    {
+        return $this->redis->hmset($id, $data);
+    }
+}
diff --git a/src/Igorw/Trashbin/Storage.php b/src/Igorw/Trashbin/Storage.php
@@ -2,24 +2,8 @@
 
 namespace Igorw\Trashbin;
 
-use Predis\Client;
-
-class Storage
+interface Storage
 {
-    private $redis;
-
-    public function __construct(Client $redis)
-    {
-        $this->redis = $redis;
-    }
-
-    public function get($id)
-    {
-        return $this->redis->hgetall($id);
-    }
-
-    public function set($id, array $data)
-    {
-        return $this->redis->hmset($id, $data);
-    }
+    public function get($id);
+    public function set($id, array $data);
 }
diff --git a/tests/unit/StorageTest.php → tests/unit/RedisStorageTest.php b/tests/unit/StorageTest.php → tests/unit/RedisStorageTest.php
@@ -2,21 +2,21 @@
 
 namespace Igorw\Trashbin;
 
-class StorageTest extends \PHPUnit_Framework_TestCase
+class RedisStorageTest extends \PHPUnit_Framework_TestCase
 {
     public function testGet()
     {
         $redis = $this->getMock('Predis\Client');
 
-        $storage = new Storage($redis);
+        $storage = new RedisStorage($redis);
         $storage->get('foo');
     }
 
     public function testSet()
     {
         $redis = $this->getMock('Predis\Client');
 
-        $storage = new Storage($redis);
+        $storage = new RedisStorage($redis);
         $storage->set('foo', array('a' => 'b'));
     }
 }