Use graph layout attribute if found #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iosonofabio
added
the
plotting
Member
|
Yes, please add a test and then we can merge. |
vtraag
pushed a commit
to vtraag/python-igraph
that referenced
this pull request
Jun 30, 2023
Plotting: use graph layout attribute if found --------- Co-authored-by: Tamás Nepusz <ntamas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #662 based on what observed in the tutorial for the workshop.
If you do:
The plotter does not know the graph already has a layout and will compute a new one. That means, if you plot multiple times you can get stochasticity if you don't reinitialize the RNG.
This PR introduces a few lines of code that check for a graph attribute "layout" and if present use it as a persistent layout.
Do you want me to write a test for this?