fix: do not wrap roxygenize in try() (#2679)#2690
Merged
Merged
Conversation
Wrapping roxygen2::roxygenize() in try() suppressed errors and let the workflow continue even when documentation generation failed, leaving stale docs and masking upstream issues. Remove try() so failures surface and halt the build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Now that roxygenize() no longer swallows errors, the step fails with "there is no package called 'igraph.r2cdocs'" because the roxygen2 dependency group was never installed. The custom roclets require igraph.r2cdocs and devtag (listed in Config/Needs/roxygen2), so add roxygen2 to the install step's needs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2679.
The
roxygenizecomposite action wrappedroxygen2::roxygenize()intry(), which swallowed any error and let theRscriptstep exit 0. As a result the workflow continued (and committed) even when documentation generation failed, leaving stale docs and masking upstream issues.This removes the
try()so failures propagate, the step exits non-zero, and the callingR-CMD-checkjob halts as intended.Change
.github/workflows/roxygenize/action.yml:try(roxygen2::roxygenize())→roxygen2::roxygenize()