Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some warnings #13

Merged
merged 3 commits into from Jan 24, 2013
Merged

Remove some warnings #13

merged 3 commits into from Jan 24, 2013

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Jan 24, 2013

This commits remove below ruby's warnings. (checked MRI 1.9.3 with $VERBOSE=true)

  • warning: assigned but unused variable
  • warning: instance variable @{ivar} not initialized
  • warning: loading in progress, circular require considered harmful

This commit removes a ruby's warning.

* "assigned but unused variable"
This commit removes a ruby's warning.

* "instance variable @{ivar} not initialized"
This commit removes a ruby's warning.

* "loading in progress, circular require considered harmful"
igrigorik added a commit that referenced this pull request Jan 24, 2013
@igrigorik igrigorik merged commit 9b4addf into igrigorik:master Jan 24, 2013
@igrigorik
Copy link
Owner

Nice. Thanks!

@kachick
Copy link
Contributor Author

kachick commented Jan 24, 2013

Thanks to merge! :)

@kachick kachick deleted the improve-remove_warnings branch January 24, 2013 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants