Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix mysql2 to 0.2.x family #11

Merged
merged 2 commits into from Jun 21, 2011

Conversation

Projects
None yet
3 participants
Contributor

dkonishi commented Jun 18, 2011

Ilya,

The current mysql2 gem (0.3.x) is not compatible with rails 3.0.x, so I fixed it to 0.2.10 version. This is the last 0.2.x family version.

Owner

igrigorik commented Jun 18, 2011

Whoa, what's up with latest mysql2? That seems like a pretty serious issue. /cc @brianmario

Contributor

dkonishi commented Jun 18, 2011

Actually there is a warning when I try to run it with the mysql2 0.3.6 (latest) is installed: "WARNING: This version of mysql2 (0.3.6) doesn't ship with the ActiveRecord adapter bundled anymore as it's now part of Rails 3.1
WARNING: Please use the 0.2.x releases if you plan on using it in Rails <= 3.0.x"

Owner

igrigorik commented Jun 18, 2011

Ah, gotcha. Hmm, instead of freezing the gem version, upgrading this project to latest rails shouldn't be much of a problem? Daniel, do you mind giving that a try? :)

Rails 3.1 pulled the mysql2 adapter in core, and since the version that used to ship with the gem in the 0.2.x releases is in the exact same autoload path as the adapter in 3.1, I had no choice but to remove it from mysql2 for the 0.3.x releases.

The two releases are exactly the same except 0.2.x has the ActiveRecord adapter, and 0.3.x doesn't (since it's in Rails 3.1). A better way of saying that is, for ActiveRecord 3.1+ you need to use mysql 0.3.x for any previous version you need to use mysql 0.2.x.

I hate that it needs to be done this way, I just couldn't think of anything better :\

Owner

igrigorik commented Jun 18, 2011

Right, thanks Brian - that makes sense. I think the best path forward here is to just update the project to latest and greatest.

Contributor

dkonishi commented Jun 18, 2011

bump to rails 3.1... :)

igrigorik added a commit that referenced this pull request Jun 21, 2011

Merge pull request #11 from dkonishi/master
Fix mysql2 to 0.2.x family

@igrigorik igrigorik merged commit 3a554bd into igrigorik:master Jun 21, 2011

Owner

igrigorik commented Jun 21, 2011

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment