Skip to content

use BloomFilter::NotSameConfigurationError instead of ArgumentError #14

Merged
merged 1 commit into from Apr 27, 2012

2 participants

@billywatson

I ran into the ArgumentError the gem was throwing and had no idea what it meant until I read through the code.

I created a named error to try and aid any users of the gem. Thanks!

@igrigorik
Owner

A pedantic request.. can we rename the error to "ConfigurationMismatch", or "FilterMismatch"? Not a fan of negations in error clases. :)

@billywatson

Feel free to be pedantic! I'm being pedantic in my pull request in the first place

@billywatson

Changed to ConfigurationMismatch

@igrigorik igrigorik merged commit 3cc543a into igrigorik:master Apr 27, 2012
@igrigorik
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.