New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use BloomFilter::NotSameConfigurationError instead of ArgumentError #14

Merged
merged 1 commit into from Apr 27, 2012

Conversation

Projects
None yet
2 participants
@billywatson

I ran into the ArgumentError the gem was throwing and had no idea what it meant until I read through the code.

I created a named error to try and aid any users of the gem. Thanks!

@igrigorik

This comment has been minimized.

Show comment
Hide comment
@igrigorik

igrigorik Apr 27, 2012

Owner

A pedantic request.. can we rename the error to "ConfigurationMismatch", or "FilterMismatch"? Not a fan of negations in error clases. :)

Owner

igrigorik commented Apr 27, 2012

A pedantic request.. can we rename the error to "ConfigurationMismatch", or "FilterMismatch"? Not a fan of negations in error clases. :)

@billywatson

This comment has been minimized.

Show comment
Hide comment
@billywatson

billywatson Apr 27, 2012

Feel free to be pedantic! I'm being pedantic in my pull request in the first place

Feel free to be pedantic! I'm being pedantic in my pull request in the first place

@billywatson

This comment has been minimized.

Show comment
Hide comment
@billywatson

billywatson Apr 27, 2012

Changed to ConfigurationMismatch

Changed to ConfigurationMismatch

igrigorik added a commit that referenced this pull request Apr 27, 2012

Merge pull request #14 from billywatson/use_better_error_message
use BloomFilter::NotSameConfigurationError instead of ArgumentError

@igrigorik igrigorik merged commit 3cc543a into igrigorik:master Apr 27, 2012

@igrigorik

This comment has been minimized.

Show comment
Hide comment
@igrigorik

igrigorik Apr 27, 2012

Owner

thanks!

Owner

igrigorik commented Apr 27, 2012

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment