Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix the pure-ruby implementation of bloom filter to work correctly. #20

Merged
merged 2 commits into from Oct 9, 2012

Conversation

Projects
None yet
2 participants
Contributor

bitterb commented Oct 8, 2012

The pure-ruby-bf.rb is still useful for comparison even though it is just for kicks. However, it does not work now. I have changed it as follows:

  • Fix a method call with the undefined name new_entry?.
  • Replace the BitSet class with the Bitset class, which is easy to install via RubyGems.

I would appreciate it if you could merge the changes above.

@igrigorik igrigorik added a commit that referenced this pull request Oct 9, 2012

@igrigorik igrigorik Merge pull request #20 from bitterb/fix-pure-ruby-bf
Fix the pure-ruby implementation of bloom filter to work correctly.
163d0cd

@igrigorik igrigorik merged commit 163d0cd into igrigorik:master Oct 9, 2012

Owner

igrigorik commented Oct 9, 2012

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment