Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for bug 41 #18

Merged
merged 1 commit into from Apr 17, 2012

Conversation

Projects
None yet
3 participants

This is a simple change integrating the code change suggested on the bug. All unit tests passed.

@igrigorik igrigorik added a commit that referenced this pull request Apr 17, 2012

@igrigorik igrigorik Merge pull request #18 from cleeland/master
Fix for bug 41
79d290d

@igrigorik igrigorik merged commit 79d290d into igrigorik:master Apr 17, 2012

Owner

igrigorik commented Apr 17, 2012

Nice. By 41, do you mean #4, and #10?

Contributor

msgerbush commented Apr 17, 2012

Thanks for doing this.

Grrr....no, it should have been #4. I copy/pasted the issue link from the wrong github window. I copy/pasted the link from the grit github window rather than from bugspots.

Sorry for the confusion. I should amend the commit message.

Contributor

msgerbush commented Apr 17, 2012

You can also use @ to reference people in github comments ;)

Owner

igrigorik commented Apr 17, 2012

@msgerbush since we have you attention, any thoughts or recommendations for #10? ;-)

Contributor

msgerbush commented Apr 17, 2012

Hmm, not sure off the top of my head. I'm a bit busy this morning, but I'll check it out tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment