Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix for bug 41 #18

Merged
merged 1 commit into from

3 participants

@cleeland

This is a simple change integrating the code change suggested on the bug. All unit tests passed.

@igrigorik igrigorik merged commit 79d290d into from
@igrigorik
Owner

Nice. By 41, do you mean #4, and #10?

@msgerbush

Thanks for doing this.

@cleeland

Grrr....no, it should have been #4. I copy/pasted the issue link from the wrong github window. I copy/pasted the link from the grit github window rather than from bugspots.

Sorry for the confusion. I should amend the commit message.

@msgerbush

You can also use @ to reference people in github comments ;)

@igrigorik
Owner

@msgerbush since we have you attention, any thoughts or recommendations for #10? ;-)

@msgerbush

Hmm, not sure off the top of my head. I'm a bit busy this morning, but I'll check it out tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 17, 2012
  1. Fix mojombo/grit#41 using suggestion from msgerbush.

    Chris Cleeland authored
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +3 −1 lib/bugspots/scanner.rb
View
4 lib/bugspots/scanner.rb
@@ -15,7 +15,9 @@ def self.scan(repo, branch = "master", depth = 500, regex = nil)
regex ||= /fix(es|ed)?|close(s|d)?/i
tree = repo.tree(branch)
- repo.commits(branch, depth).each do |commit|
+
+ commit_list = repo.git.rev_list({:max_count => false, :no_merges => true, :pretty => "raw", :timeout => false}, branch)
+ Grit::Commit.list_from_string(repo, commit_list).each do |commit|
if commit.message =~ regex
files = commit.stats.files.map {|s| s.first}.select{ |s| tree/s }
fixes << Fix.new(commit.short_message, commit.date, files)
Something went wrong with that request. Please try again.