Add Processor for Google Stylesheets #3

Merged
merged 1 commit into from Nov 21, 2011

3 participants

@guilleiguaran
Collaborator

No description provided.

@igrigorik igrigorik merged commit f6906dc into igrigorik:master Nov 21, 2011
@igrigorik
Owner

Great stuff, thanks!

@igrigorik
Owner

Hmm, it seems like I'm getting the following exception post this merge:

Compiled /git/closure-sprockets/vendor/assets/javascripts/soyutils.js  (7ms)  (pid 35250)
Error compiling asset application.js:
Sprockets::CircularDependencyError: /git/klosure/vendor/assets/closure-library/closure/goog/base.js has already been required

Have you run into this?

@guilleiguaran
Collaborator

Actually, I got it before of the merge, looks like it was caused by something changed in the last versions of Sprockets 2.0.x

@igrigorik
Owner

Ah, well then. :-)

Well, I think that's our cue then to resolve #5. I think the error its throwing is perfectly valid.. Instead of the naive implementation, we need to do the proper deps graph as done by the calcdeps.py

http://code.google.com/p/closure-library/source/browse/trunk/closure/bin/calcdeps.py

@lypanov

Without calcdeps many things don't work anyway. One of the reasons I'm now using clojurescript instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment