graph/graphviz_dot not installed, graphing functionality not included #1

Closed
heaven opened this Issue Jun 23, 2012 · 2 comments

Comments

Projects
None yet
3 participants

heaven commented Jun 23, 2012

Hi, can you please mute this error message?

Contributor

louismullie commented Jul 24, 2012

@igrigorik I just released Robert Feld's original graph classes as a gem: https://github.com/louismullie/graphr. I have left the API and the class structure intact. Perhaps this could be added as a dependency in the gemspec? This would eliminate the need for users to manually download and install these useful classes. At the same time, this solves the warning problem described above, and eliminates the need for an odd require-check.

Basically, in addition to adding "graphr" to the gemspec,

begin
  require 'graph/graphviz_dot'
rescue LoadError
  STDERR.puts "graph/graphviz_dot not installed, graphing functionality not included."
end

would simply become:

require 'graph/graphviz_dot'

I can submit a pull request if you agree with this.

Owner

igrigorik commented Jul 24, 2012

That makes sense to me - make a quick pull request?

@igrigorik igrigorik closed this Nov 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment