Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack level too deep #13

Closed
Numerico opened this issue Sep 4, 2013 · 4 comments
Closed

stack level too deep #13

Numerico opened this issue Sep 4, 2013 · 4 comments

Comments

@Numerico
Copy link

Numerico commented Sep 4, 2013

I think I found a weird behaviour too.
Getting

Failure/Error: Unable to find matching line from backtrace
     SystemStackError:
       stack level too deep
     # /home/numerico/.rvm/gems/ruby-1.9.3-p392/gems/decisiontree-0.4.1/lib/decisiontree/id3_tree.rb:122

when I give it attributes with numerical names
for eg.

attributes = ['1', '2'] # NUMERICAL
training = [[1, 1, true], [1,2,false] #... ]

but this would work

attributes = ['one', 'two'] #NON NUMERICAL
training = #...

does this make any sense?

@igrigorik
Copy link
Owner

Could you post a full example? Trying to reproduce it here, but so far no luck.. "works here".

@Numerico
Copy link
Author

Numerico commented Sep 9, 2013

Hold on please, I'll build a test for this asap.

@Numerico
Copy link
Author

Ok, this commit reproduces the issue Numerico@c820a56
I'm trying to submit a pull request but my Firefox is kind of old school it seems..

@igrigorik
Copy link
Owner

The code really needs a refactor.. but this does the trick. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants