Updated benchmarks to be operational again #188

Merged
merged 3 commits into from Apr 19, 2012

2 participants

@Zapotek

And I also updated them to make proper use of Typhoeus because you were running it synchronously, which kind of defeats the point of its existence.

PS. I noticed that em-http-request experiences a lot of failed requests (judging by the errback counter, aroung 45 on each run).

@igrigorik igrigorik and 1 other commented on an outdated diff Apr 19, 2012
benchmarks/clients.rb
-# | em-http-request | 0.041866 |
-# +------------------------------+----------+
-# | Net::HTTP (persistent) | 0.098379 |
-# +------------------------------+----------+
-# | Net::HTTP | 0.103786 |
-# +------------------------------+----------+
-# | RestClient | 0.111841 |
-# +------------------------------+----------+
-# | HTTParty | 0.118632 |
-# +------------------------------+----------+
-# | open-uri | 0.170172 |
-# +------------------------------+----------+
+#+------------------------------+-----------+
+#| tach | total |
+#+------------------------------+-----------+
+#| Typhoeus | 0.005322 |
@igrigorik
Owner
igrigorik added a line comment Apr 19, 2012

That seems fishy. A little too fast? :)

@Zapotek
Zapotek added a line comment Apr 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Zapotek

The memoization thing caches responses so when you request the same URL it returns it from memory.
One thing that still worries me though is the failed requests, it sort of comes and goes.

So glad I was so off though, it means that my system can get an amazing performance boost simply by plugging in em-http-request. :)

@igrigorik
Owner

That makes more sense. Thanks for the fix! :)

@igrigorik igrigorik merged commit 6159c16 into igrigorik:master Apr 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment