Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Split response fix #20

wants to merge 6 commits into


None yet
2 participants

mdpye commented May 7, 2014

Did not handle case where packet boundaries split a body from its line terminator exactly. Line terminator not consumed, nor anything past it. For example:

OK 5\r\n12345
\r\nDELETED 10\r\n

Considerably simplified multi-packet reading and body-extraction logic.

danielwaterworth and others added some commits May 9, 2013

Specify the problem
If one packet contains exactly the declared data size, but not the line
terminator chars, then they will not be consumed and will block
consumption of further commands
Fix handling of responses which take bodies
There was miscounting in the consuming of the bodies when the associated
line terminator did not turn up in the same delivery.

Removed the check on the return value of the `handle` methods. They
duplicate the check made in `handles?` and nothing is ever passed to
`handle` without first being tested in `handles?`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment