Use bundler #4
Merged
Use bundler #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 23, 2011 11:39
|
|
||
| s.add_dependency('eventmachine') | ||
| s.add_dependency 'eventmachine', ['>= 1.0.0.beta.3'] |
There was a problem hiding this comment.
Jack should work with older versions of eventamchine. At a max, I think this should be 0.12.10 until 1.0 is out.
|
This is looking good. One thing, I'm not a fan of having .rvmrc files committed. If you can remove that and bump the required EM version down this looks merge-able. |
added 2 commits
May 23, 2011 13:54
The usage of >= should allow projects using more recent versions to coexist with em-jack.
|
Take a look at 8cadfff. I think that should satisfy some projects I've encountered using the EventMachine betas, and those using older EventMachine. |
|
Looks good, thanks for the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use Bundler, and its various tools.