each_job fiber compliant #8

Merged
merged 2 commits into from Aug 30, 2011

Conversation

Projects
None yet
3 participants
@fonzo14
Contributor

fonzo14 commented Aug 29, 2011

No description provided.

lib/em-jack/connection.rb
- r.callback do |job|
- blk.call(job)
- EM.next_tick { work.call }
+ unless @fiberized

This comment has been minimized.

Show comment Hide comment
@dj2

dj2 Aug 29, 2011

Contributor

Can you flip this to be an if (swap the blocks around)? I find, with an else statement, it's easier for me to parse when it's an if instead of an unless. If there is no else, I'm happy with unless, heh.

@dj2

dj2 Aug 29, 2011

Contributor

Can you flip this to be an if (swap the blocks around)? I find, with an else statement, it's easier for me to parse when it's an if instead of an unless. If there is no else, I'm happy with unless, heh.

@fonzo14

This comment has been minimized.

Show comment Hide comment
@fonzo14

fonzo14 Aug 30, 2011

Contributor

better ?

Contributor

fonzo14 commented Aug 30, 2011

better ?

dj2 added a commit that referenced this pull request Aug 30, 2011

Merge pull request #8 from fonzo14/master
each_job  fiber compliant

@dj2 dj2 merged commit 351704a into igrigorik:master Aug 30, 2011

@jherdman

This comment has been minimized.

Show comment Hide comment
@jherdman

jherdman Aug 30, 2011

Contributor

Ah, thank you! unless and then else always gives me the willies. The brackets around @fiberized, however, does too.

Ah, thank you! unless and then else always gives me the willies. The brackets around @fiberized, however, does too.

This comment has been minimized.

Show comment Hide comment
@dj2

dj2 Aug 30, 2011

Contributor

patches accepted, heh.

Contributor

dj2 replied Aug 30, 2011

patches accepted, heh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment