Add support for connection by hostname #2

Merged
merged 2 commits into from Sep 28, 2011

Conversation

Projects
None yet
2 participants
Contributor

meh commented Sep 27, 2011

Looking at socksify-ruby and em-socksify I found what was missing.

My em-http-request thingy doesn't work yet, but now I don't know where the error is.

If you want to check out the code that uses em-http-request it's here: https://github.com/meh/torb/blob/master/puppet/puppet.rb

I'm not sure I follow these changes. How is the end result any different? We're still resolving the hostname and sending the same bytes over the wire?

Owner

igrigorik commented Sep 28, 2011

Hmm, to answer my own question, I think I'm following it now: if the name can't be resolved then pack it and forward as is.

Interesting... not familiar with Tor internals, hence the confusion!

igrigorik added a commit that referenced this pull request Sep 28, 2011

Merge pull request #2 from meh/master
Add support for connection by unresolvable hostname (Tor support)

@igrigorik igrigorik merged commit b6b387b into igrigorik:master Sep 28, 2011

Contributor

meh commented Sep 28, 2011

Keep in mind that I can't get it to work properly yet, if you could give it a look it would be best, I know pretty much nothing about SOCKS (or Tor internals), and I really need this to work or I can't make my tor2web :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment