Rewrote almost everything, now works properly with Tor #3

Closed
wants to merge 5 commits into
from

Projects

None yet

2 participants

@meh
meh commented Sep 28, 2011

Yeah well, did some more research, appears to be that with SOCKS5 you don't have to resolve the domain by yourself, you just have to pass it to it and it will do its job.

Made it a bit more modular, now it's a lot easier to implement SOCKS4 if wanted.

Please merge and make a new gem version.

Ran the spec succesfully both on MRI 1.8 and MRI 1.9 and my tor2web implementation works flawlessly.

If you want to add me to the AUTHORS or something it would be appreciated, but really doesn't matter :)

Peace.

@igrigorik

Why do we need this, and the remove_instance_variable code below?

meh replied Oct 14, 2011

Well, I thought cleaning up the instance variables after we're done would remove some not needed data.

Wouldn't those variables stay there even when we don't need them anymore?

Owner

Removing the method is a no_op, and same applies for the instance variables: we do this right before calling the error callback, which means the object will likely get GC'ed shortly anyway.

@igrigorik

@socks_data.slice(min_size, size)

meh replied Oct 14, 2011

Fixed.

@igrigorik
Owner

Hmm, not sure why GH didn't auto close this.. merged. Thanks!

@igrigorik igrigorik closed this Oct 15, 2011
@meh
meh commented Oct 15, 2011

Thank you for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment