Add optional hash options. #6

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@meh
Contributor

meh commented Mar 28, 2012

Hopefully github will be smart enough to merge properly, this pull request depends on the other.

@igrigorik

This comment has been minimized.

Show comment
Hide comment
@igrigorik

igrigorik Mar 30, 2012

Owner

I'm not sure we should support two completely different ways to instantiate the connection.. either the hash, or the parameters. Maybe one day we'll have 2.0 with named parameters, but as such, this doesn't seem to win us anything, short of making the API more complicated?

Owner

igrigorik commented Mar 30, 2012

I'm not sure we should support two completely different ways to instantiate the connection.. either the hash, or the parameters. Maybe one day we'll have 2.0 with named parameters, but as such, this doesn't seem to win us anything, short of making the API more complicated?

@meh meh closed this Mar 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment