Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add a simplified way to handle SOCKS connections. #8

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

meh commented May 18, 2012

I added an helper module function to deal with socks connections, it should be the main way to use em-socksify unless advanced features are needed.

Any feedback on this?

Owner

igrigorik commented May 19, 2012

Cool idea. What do you have in mind by "advanced features".

I like the interface, but to be honest given that it saves all of 2 or 3 lines of code, not sure that I see the benefit of exposing two identical interfaces in the gem -- might create more confusion than help.

Contributor

meh commented May 19, 2012

The "advanced features" are error handling, multiple callbacks, having the connection_completed be called when you get connected to the proxy and not when the SOCKS connection has ended.

The reason for the simplified interface is that right now using socksify doesn't have a default error, using connect_through it behaves like it did before.

For instance, the example in the README is good with the connect_through interface, while what I use it for will need the advanced method.

@igrigorik igrigorik closed this Aug 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment