Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Doesn't parse absolute request URIs #73

Closed
aslakhellesoy opened this Issue Feb 23, 2012 · 4 comments

Comments

Projects
None yet
3 participants

A valid Request-URI can be of the form:

GET ws://0.0.0.0:8080 HTTP/1.1
Host: 0.0.0.0
Connection: Upgrade
Upgrade: websocket
Sec-WebSocket-Version: 13
Sec-WebSocket-Key: sABm0xRIXB37QsIbDGxdkA==

However, em-websocket only supports abs_path, not absoluteURI - see

PATH = /^(\w+) (\/[^\s]*) HTTP\/1\.1$/

Collaborator

mloughran commented Feb 23, 2012

Hi Aslak :) I've been planning to replace the custom parsing with http_parser.rb for a while now (#44) - maybe now is the time to Just Do It.

Owner

igrigorik commented Feb 23, 2012

+1 for move to http_parser.rb. Having said that, the above should be fixable with a simple change to the regex as well (in the short term). :-)

Collaborator

mloughran commented Jan 22, 2013

0.4.0 uses http_parser.rb, finally :)

@mloughran mloughran closed this Jan 22, 2013

Owner

igrigorik commented Jan 23, 2013

woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment