New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder structure and app.yaml to fix App Engine deployment #56

Merged
merged 2 commits into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@mxbi
Contributor

mxbi commented Aug 17, 2017

This pull request fixes #55, which I believe occurs due to an update in the app engine API meaning several changes need to be made so that the project is able to deploy using the standard deployment instructions.

Three things are changed in this commit:

  1. The contents of the ga-beacon subfolder have been moved into the root directory (ga-beacon.go and page.html). This is because when the go file is in a subfolder it is not discovered by gcloud app deploy.
  2. ga-beacon.go is updated to point to the new location of page.html, for obvious reasons.
  3. The application and version parameters have been removed from app.yaml. This is because it seems gcloud appears to have deprecated this field in favour of using --project and --version flags in gcloud app deploy. Without removing these parameters, gcloud complains with the following error:
ERROR: (gcloud.app.deploy) The [application] field is specified in file [/home/mikel/ga-beacon/app.yaml]. This field is not used by gcloud and must be removed. Project name should instead be specified either by `gcloud config set project MY_PROJECT` or by setting the `--project` flag on individual command executions.

With these changes, the repo successfuly deploys on my Ubuntu box with the newest gcloud version (SDK 164.0.0). I would be grateful if someone else could test this to see if it also deploys for them.

@igrigorik

👍 looks good, thanks for detailed writeup as well!

@igrigorik igrigorik merged commit af00191 into igrigorik:master Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment