Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: igrigorik/githubarchive.org
base: 7ea23f1d1a
...
head fork: igrigorik/githubarchive.org
compare: 6e3b428d24
  • 2 commits
  • 1 file changed
  • 0 commit comments
  • 2 contributors
Commits on Aug 12, 2012
@soult soult web: Fix broken github buttons
The github button moved from markdotto.github.com to ghbtns.com, and the old
URL simply 404ed. However, the Github Pages 404 page may not be used within a
frame/iframe, so when JavaScript is enabled, it would display an error message
and remove the outer frame by redirecting to itself. Thus, any visitor to
githubarchive.org with JavaScript enabled would be redirected to a Github Pages
404 page.
dfb8d62
@igrigorik Merge pull request #13 from soult/master
Github button URL changed in a way that it breaks the website for anyone w/ JavaScript
6e3b428
Showing with 2 additions and 2 deletions.
  1. +2 −2 web/index.html
View
4 web/index.html
@@ -40,7 +40,7 @@ <h1 style="margin-bottom:0.5em">
GitHub <span style="color:#c60000">Archive</span>
<span style="float:right; margin-top:0.25em">
- <iframe src="http://markdotto.github.com/github-buttons/github-btn.html?user=igrigorik&repo=githubarchive.org&type=watch&count=true" allowtransparency="true" frameborder="0" scrolling="0" width="110px" height="20px"></iframe>
+ <iframe src="http://ghbtns.com/github-btn.html?user=igrigorik&repo=githubarchive.org&type=watch&count=true" allowtransparency="true" frameborder="0" scrolling="0" width="110px" height="20px"></iframe>
<g:plusone size="medium"></g:plusone>
<a href="https://twitter.com/share" class="twitter-share-button" data-text="GitHub public timeline archive @ " data-related="igrigorik">Tweet</a>
</span>
@@ -120,7 +120,7 @@ <h1 style="margin-bottom:0.5em">
<p>
<a href="http://www.igvita.com" rel="me" style="vertical-align:top; margin-right:1em"><strong>Ilya Grigorik</strong></a>
<span style="float:right;">
- <iframe src="http://markdotto.github.com/github-buttons/github-btn.html?user=igrigorik&type=follow&count=true" allowtransparency="true" frameborder="0" scrolling="0" width="165px" height="20px" style="margin-right:1em"></iframe>
+ <iframe src="http://ghbtns.com/github-btn.html?user=igrigorik&type=follow&count=true" allowtransparency="true" frameborder="0" scrolling="0" width="165px" height="20px" style="margin-right:1em"></iframe>
<a href="https://twitter.com/igrigorik" class="twitter-follow-button" data-show-count="true">Follow @igrigorik</a>
</span>
</p>

No commit comments for this range

Something went wrong with that request. Please try again.