Be able to override the "pub build" command #26

Merged
merged 77 commits into from Jan 8, 2014

9 participants

@GeReinhart

See Issue #25

and others added some commits May 24, 2012
@igrigorik Merge pull request #1 from tomykaira/master
Run x64 binary on heroku
66e02a4
@igrigorik use mirrored 64 bit image + update readme 9d92287
@igrigorik simple hello world web app example fd6e059
@igrigorik use latest dart build c575865
@igrigorik disable cache logic 06fe0c2
@igrigorik update readme with latest build date 956588b
@igrigorik fix example to use https buildpack URL, fixes #2 0c578cc
@devoncarew devoncarew updating to the 64 bit SDK build 7fd7eda
@igrigorik Merge pull request #3 from devoncarew/master
update the heroku build pack to the latest Dart 64 bit linux SDK
2e465c7
@sethladd sethladd Dart now ships 64 bit Linux SDKs. f4f7d59
@sethladd sethladd Merge pull request #4 from sethladd/master
Remove disclaimer from readme.
83ca510
@sethladd sethladd Point to dart in dart-sdk a09e5e5
@sethladd sethladd Merge pull request #5 from sethladd/master
Point to correct dart bin in SDK
68b81d5
Seth Ladd parseInt is now parse on int de330a1
Seth Ladd update to dart m1 syntax c74ae71
Matthias Knoll adding pub support to heroku buildpack
Signed-off-by: Matthias Knoll <matthias@bravenewtalent.com>
9bf307e
@igrigorik Merge pull request #6 from kohlikohl/master
Supporting pub on heroku
7cdbbe2
@sethladd sethladd add pubspec to sample and move main into bin c885f53
@sethladd sethladd make the pub cache dir if it doesn't exist 7eb6ca1
@eee-c eee-c Install all pubspec.yaml dependencies
Not just those in the root directory of the application. Also,
manually fix the symlink in any web sub-directories.
9baa918
@igrigorik Merge pull request #9 from eee-c/all-pubspecs
Install all pubspec.yaml dependencies
14f0de0
@financeCoding financeCoding adding ARCHIVE env 324ecfc
@financeCoding financeCoding adding making pub verbose 8439e8a
@financeCoding financeCoding removed --verbose 28588a0
@financeCoding financeCoding Updated read me 8418dfe
@ggirou ggirou Update test-app/bin/main.dart
Change "import 'dart:json'" to "import 'dart:json' as JSON" since there is no JSON class anymore.
6f09cd7
@sethladd sethladd Merge pull request #12 from ggirou/patch-1
Update test-app/bin/main.dart
1872546
@nfrancois nfrancois Update server code with dart:io V2 6e3bbc1
@nfrancois nfrancois Fix ident 4837df1
@sethladd sethladd Merge pull request #14 from nfrancois/updateDartIO
Update test-app/bin/main.dart with dart:io V2
74a7c02
Michael Houston Run build.dart 70f5eaf
Michael Houston Run build.dart 7533284
Michael Houston Run build.dart 0372341
Michael Houston Updated documentation and console output d024e53
@sethladd sethladd Merge pull request #15 from kothar/master
Run build.dart if present
f3df23f
@sethladd sethladd Merge pull request #10 from financeCoding/master
adding ARCHIVE
5e3a302
@nfrancois nfrancois Fix response.addString 7d3e65c
@selkhateeb selkhateeb Allow for custom builds to be downloadable
heroku config:set DART_SDK_URL=<url to download tar.gz file>
eeefc65
@sethladd sethladd Merge pull request #19 from nfrancois/fixAddString
Fix response.addString
8ff8d51
@sethladd sethladd Merge pull request #20 from selkhateeb/master
Allow for custom builds to be downloaded
c41694b
@sethladd sethladd update sample server 533f12f
sethladd add a SDK built by ubuntu 10.04 28a4798
@sethladd sethladd don't put the SDK in just yet df43651
@sethladd sethladd be more specific when downloading the SDK bc7e667
@sethladd sethladd print if dart command was found d1da113
@sethladd sethladd print out version from dart command c073aa3
@sethladd sethladd unmute curl 24e5821
@sethladd sethladd unmute tar c6bbf9a
@sethladd sethladd what's in app? a510086
@sethladd sethladd print before moving on 54ea8e3
@sethladd sethladd print before moving on 6f9f343
@sethladd sethladd print before moving on 72744f2
@sethladd sethladd print before moving on 67e4929
@sethladd sethladd display the machine type 199ba62
@sethladd sethladd reformat README a4ee8b4
@sethladd sethladd print dart version ed74f64
@sethladd sethladd run build.dart with --deploy 6e280e2
@sethladd sethladd use non-deprecated pub get 6aba7cb
@sethladd sethladd remove unnecessary packages d340963
@sethladd sethladd more debugging f7d624a
@sethladd sethladd get rid of packages_dir and put pub_cache into /app f3d0660
@sethladd sethladd debug 97e7e29
@sethladd sethladd more debug 25e0eb5
@sethladd sethladd add comments to explain the insanity 4b9af9a
@sethladd sethladd Clean up the README 8c60b78
@sethladd sethladd add a web app that requires pub build 34a1f69
@sethladd sethladd fix links 607349e
@sethladd sethladd more instructions in README and better path resolution for server 101351f
@sethladd sethladd Merge pull request #23 from sethladd/master
More complex server example, better README
1c8fe38
@GeReinhart GeReinhart Be able to override the default pub build command 75fec71
@GeReinhart GeReinhart Display properly the $DART_BUILD_CMD command 26534df
@GeReinhart GeReinhart Add documentation DART_BUILD_CMD 681b832
@sethladd sethladd commented on an outdated diff Jan 3, 2014
@@ -125,6 +125,14 @@ The sample app's `Procfile` looks like:
web: ./dart-sdk/bin/dart bin/basic_http_server.dart
```
+### Overriding the build command
+
+By default `pub build` is launched after the `pub get`, it can be usefull to use another command: for instance `pub build --mode=debug` or `/app/dart-sdk/bin/dart build.dart` :
@sethladd
Collaborator
sethladd added a line comment Jan 3, 2014

can you break this line to 80 chars?

also, typo on usefull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@sethladd sethladd commented on an outdated diff Jan 3, 2014
@@ -64,7 +64,15 @@ for filename in `find . -name pubspec.yaml | grep -v dart-sdk | grep -v pub-cach
message "*** Running pub build"
- /app/dart-sdk/bin/pub build
+ if [[ -z "$DART_BUILD_CMD" ]]
+ then
+ echo 'Use the default command: "pub build"'
+ /app/dart-sdk/bin/pub build
+ else
+ echo "Use custom command: \"$DART_BUILD_CMD\""
@sethladd
Collaborator
sethladd added a line comment Jan 3, 2014

How about s/Use custom command/Building with

And then use 'Building with' both here and for default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@sethladd sethladd commented on an outdated diff Jan 6, 2014
@@ -64,7 +64,16 @@ for filename in `find . -name pubspec.yaml | grep -v dart-sdk | grep -v pub-cach
message "*** Running pub build"
- /app/dart-sdk/bin/pub build
+ if [[ -z "$DART_BUILD_CMD" ]]
+ then
+ message 'Building with "pub build"'
+ /app/dart-sdk/bin/pub build
+ else
+ message "Use custom command"
@sethladd
Collaborator
sethladd added a line comment Jan 6, 2014

Can we drop this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@sethladd
Collaborator

Thanks! Looks good. Can you merge with master and repush? I'll them merge your change.

@GeReinhart

Don't really get what I'm supposed to do here.
It's my first pull request ever and I though you would be able to merge the pull request at this point. Maybe not.

@sethladd
Collaborator

You're close! I think you need to do this on your fork:

(assuming you have a remote called upsteam, which is this repo)

git checkout master
git fetch upstream
git merge upstream/master
git checkout your_branch_with_these_changes
git merge master
git push origin your_branch_with_these_changes

Then I think this PR will be able to be merged.

Sorry for the trouble, we're almost there.

@GeReinhart

Sorry mixed up my merge...

@GeReinhart

Should be ok now. see it running : https://drone.io/github.com/GeReinhart/dart-app-deploy-to-cloud/21

Hope you will be able to merge the pull request (before other commit on the master ;).

@sethladd
Collaborator

Thanks!

@sethladd sethladd merged commit 532705e into igrigorik:master Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment