Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Be able to override the "pub build" command #26

Merged
merged 77 commits into from

9 participants

Gérald Reinhart Seth Ladd Ilya Grigorik Devon Carew Chris Strom Adam Singer Guillaume Girou Nicolas François Sam
Gérald Reinhart

See Issue #25

and others added some commits
Ilya Grigorik Merge pull request #1 from tomykaira/master
Run x64 binary on heroku
66e02a4
Ilya Grigorik use mirrored 64 bit image + update readme 9d92287
Ilya Grigorik simple hello world web app example fd6e059
Ilya Grigorik use latest dart build c575865
Ilya Grigorik disable cache logic 06fe0c2
Ilya Grigorik update readme with latest build date 956588b
Ilya Grigorik fix example to use https buildpack URL, fixes #2 0c578cc
Devon Carew devoncarew updating to the 64 bit SDK build 7fd7eda
Ilya Grigorik Merge pull request #3 from devoncarew/master
update the heroku build pack to the latest Dart 64 bit linux SDK
2e465c7
Seth Ladd sethladd Dart now ships 64 bit Linux SDKs. f4f7d59
Seth Ladd sethladd Merge pull request #4 from sethladd/master
Remove disclaimer from readme.
83ca510
Seth Ladd sethladd Point to dart in dart-sdk a09e5e5
Seth Ladd sethladd Merge pull request #5 from sethladd/master
Point to correct dart bin in SDK
68b81d5
Seth Ladd parseInt is now parse on int de330a1
Seth Ladd update to dart m1 syntax c74ae71
Matthias Knoll adding pub support to heroku buildpack
Signed-off-by: Matthias Knoll <matthias@bravenewtalent.com>
9bf307e
Ilya Grigorik Merge pull request #6 from kohlikohl/master
Supporting pub on heroku
7cdbbe2
Seth Ladd sethladd add pubspec to sample and move main into bin c885f53
Seth Ladd sethladd make the pub cache dir if it doesn't exist 7eb6ca1
Chris Strom eee-c Install all pubspec.yaml dependencies
Not just those in the root directory of the application. Also,
manually fix the symlink in any web sub-directories.
9baa918
Ilya Grigorik Merge pull request #9 from eee-c/all-pubspecs
Install all pubspec.yaml dependencies
14f0de0
Adam Singer financeCoding adding ARCHIVE env 324ecfc
Adam Singer financeCoding adding making pub verbose 8439e8a
Adam Singer financeCoding removed --verbose 28588a0
Adam Singer financeCoding Updated read me 8418dfe
Guillaume Girou ggirou Update test-app/bin/main.dart
Change "import 'dart:json'" to "import 'dart:json' as JSON" since there is no JSON class anymore.
6f09cd7
Seth Ladd sethladd Merge pull request #12 from ggirou/patch-1
Update test-app/bin/main.dart
1872546
Nicolas François nfrancois Update server code with dart:io V2 6e3bbc1
Nicolas François nfrancois Fix ident 4837df1
Seth Ladd sethladd Merge pull request #14 from nfrancois/updateDartIO
Update test-app/bin/main.dart with dart:io V2
74a7c02
Michael Houston Run build.dart 70f5eaf
Michael Houston Run build.dart 7533284
Michael Houston Run build.dart 0372341
Michael Houston Updated documentation and console output d024e53
Seth Ladd sethladd Merge pull request #15 from kothar/master
Run build.dart if present
f3df23f
Seth Ladd sethladd Merge pull request #10 from financeCoding/master
adding ARCHIVE
5e3a302
Nicolas François nfrancois Fix response.addString 7d3e65c
Sam selkhateeb Allow for custom builds to be downloadable
heroku config:set DART_SDK_URL=<url to download tar.gz file>
eeefc65
Seth Ladd sethladd Merge pull request #19 from nfrancois/fixAddString
Fix response.addString
8ff8d51
Seth Ladd sethladd Merge pull request #20 from selkhateeb/master
Allow for custom builds to be downloaded
c41694b
Seth Ladd sethladd update sample server 533f12f
sethladd add a SDK built by ubuntu 10.04 28a4798
Seth Ladd sethladd don't put the SDK in just yet df43651
Seth Ladd sethladd be more specific when downloading the SDK bc7e667
Seth Ladd sethladd print if dart command was found d1da113
Seth Ladd sethladd print out version from dart command c073aa3
Seth Ladd sethladd unmute curl 24e5821
Seth Ladd sethladd unmute tar c6bbf9a
Seth Ladd sethladd what's in app? a510086
Seth Ladd sethladd print before moving on 54ea8e3
Seth Ladd sethladd print before moving on 6f9f343
Seth Ladd sethladd print before moving on 72744f2
Seth Ladd sethladd print before moving on 67e4929
Seth Ladd sethladd display the machine type 199ba62
Seth Ladd sethladd reformat README a4ee8b4
Seth Ladd sethladd print dart version ed74f64
Seth Ladd sethladd run build.dart with --deploy 6e280e2
Seth Ladd sethladd use non-deprecated pub get 6aba7cb
Seth Ladd sethladd remove unnecessary packages d340963
Seth Ladd sethladd more debugging f7d624a
Seth Ladd sethladd get rid of packages_dir and put pub_cache into /app f3d0660
Seth Ladd sethladd debug 97e7e29
Seth Ladd sethladd more debug 25e0eb5
Seth Ladd sethladd add comments to explain the insanity 4b9af9a
Seth Ladd sethladd Clean up the README 8c60b78
Seth Ladd sethladd add a web app that requires pub build 34a1f69
Seth Ladd sethladd fix links 607349e
Seth Ladd sethladd more instructions in README and better path resolution for server 101351f
Seth Ladd sethladd Merge pull request #23 from sethladd/master
More complex server example, better README
1c8fe38
Gérald Reinhart GeReinhart Be able to override the default pub build command 75fec71
Gérald Reinhart GeReinhart Display properly the $DART_BUILD_CMD command 26534df
Gérald Reinhart GeReinhart Add documentation DART_BUILD_CMD 681b832
README.md
@@ -125,6 +125,14 @@ The sample app's `Procfile` looks like:
web: ./dart-sdk/bin/dart bin/basic_http_server.dart
```
+### Overriding the build command
+
+By default `pub build` is launched after the `pub get`, it can be usefull to use another command: for instance `pub build --mode=debug` or `/app/dart-sdk/bin/dart build.dart` :
Seth Ladd Collaborator
sethladd added a note

can you break this line to 80 chars?

also, typo on usefull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bin/compile
@@ -64,7 +64,15 @@ for filename in `find . -name pubspec.yaml | grep -v dart-sdk | grep -v pub-cach
message "*** Running pub build"
- /app/dart-sdk/bin/pub build
+ if [[ -z "$DART_BUILD_CMD" ]]
+ then
+ echo 'Use the default command: "pub build"'
+ /app/dart-sdk/bin/pub build
+ else
+ echo "Use custom command: \"$DART_BUILD_CMD\""
Seth Ladd Collaborator
sethladd added a note

How about s/Use custom command/Building with

And then use 'Building with' both here and for default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bin/compile
@@ -64,7 +64,16 @@ for filename in `find . -name pubspec.yaml | grep -v dart-sdk | grep -v pub-cach
message "*** Running pub build"
- /app/dart-sdk/bin/pub build
+ if [[ -z "$DART_BUILD_CMD" ]]
+ then
+ message 'Building with "pub build"'
+ /app/dart-sdk/bin/pub build
+ else
+ message "Use custom command"
Seth Ladd Collaborator
sethladd added a note

Can we drop this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Seth Ladd
Collaborator

Thanks! Looks good. Can you merge with master and repush? I'll them merge your change.

Gérald Reinhart

Don't really get what I'm supposed to do here.
It's my first pull request ever and I though you would be able to merge the pull request at this point. Maybe not.

Seth Ladd
Collaborator

You're close! I think you need to do this on your fork:

(assuming you have a remote called upsteam, which is this repo)

git checkout master
git fetch upstream
git merge upstream/master
git checkout your_branch_with_these_changes
git merge master
git push origin your_branch_with_these_changes

Then I think this PR will be able to be merged.

Sorry for the trouble, we're almost there.

Gérald Reinhart

Sorry mixed up my merge...

Gérald Reinhart

Should be ok now. see it running : https://drone.io/github.com/GeReinhart/dart-app-deploy-to-cloud/21

Hope you will be able to merge the pull request (before other commit on the master ;).

Seth Ladd
Collaborator

Thanks!

Seth Ladd sethladd merged commit 532705e into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 24, 2012
  1. Merge pull request #1 from tomykaira/master

    authored
    Run x64 binary on heroku
Commits on May 31, 2012
  1. use latest dart build

    authored
  2. disable cache logic

    authored
Commits on Jul 18, 2012
Commits on Jul 27, 2012
  1. Devon Carew
  2. Merge pull request #3 from devoncarew/master

    authored
    update the heroku build pack to the latest Dart 64 bit linux SDK
Commits on Aug 15, 2012
  1. Seth Ladd
  2. Seth Ladd

    Merge pull request #4 from sethladd/master

    sethladd authored
    Remove disclaimer from readme.
  3. Seth Ladd

    Point to dart in dart-sdk

    sethladd authored
  4. Seth Ladd

    Merge pull request #5 from sethladd/master

    sethladd authored
    Point to correct dart bin in SDK
Commits on Sep 20, 2012
  1. parseInt is now parse on int

    Seth Ladd authored
Commits on Oct 26, 2012
  1. update to dart m1 syntax

    Seth Ladd authored
Commits on Nov 19, 2012
  1. adding pub support to heroku buildpack

    Matthias Knoll authored
    Signed-off-by: Matthias Knoll <matthias@bravenewtalent.com>
Commits on Nov 26, 2012
  1. Merge pull request #6 from kohlikohl/master

    authored
    Supporting pub on heroku
Commits on Nov 29, 2012
  1. Seth Ladd
  2. Seth Ladd
Commits on Dec 2, 2012
  1. Chris Strom

    Install all pubspec.yaml dependencies

    eee-c authored
    Not just those in the root directory of the application. Also,
    manually fix the symlink in any web sub-directories.
  2. Merge pull request #9 from eee-c/all-pubspecs

    authored
    Install all pubspec.yaml dependencies
Commits on Jan 16, 2013
  1. Adam Singer

    adding ARCHIVE env

    financeCoding authored
  2. Adam Singer
  3. Adam Singer

    removed --verbose

    financeCoding authored
  4. Adam Singer

    Updated read me

    financeCoding authored
Commits on Feb 3, 2013
  1. Guillaume Girou

    Update test-app/bin/main.dart

    ggirou authored
    Change "import 'dart:json'" to "import 'dart:json' as JSON" since there is no JSON class anymore.
Commits on Feb 4, 2013
  1. Seth Ladd

    Merge pull request #12 from ggirou/patch-1

    sethladd authored
    Update test-app/bin/main.dart
Commits on Mar 4, 2013
  1. Nicolas François
Commits on Mar 5, 2013
  1. Nicolas François

    Fix ident

    nfrancois authored
  2. Seth Ladd

    Merge pull request #14 from nfrancois/updateDartIO

    sethladd authored
    Update test-app/bin/main.dart with dart:io V2
Commits on Mar 28, 2013
  1. Run build.dart

    Michael Houston authored
  2. Run build.dart

    Michael Houston authored
  3. Run build.dart

    Michael Houston authored
  4. Updated documentation and console output

    Michael Houston authored
Commits on Mar 29, 2013
  1. Seth Ladd

    Merge pull request #15 from kothar/master

    sethladd authored
    Run build.dart if present
Commits on Jun 4, 2013
  1. Seth Ladd

    Merge pull request #10 from financeCoding/master

    sethladd authored
    adding ARCHIVE
Commits on Sep 16, 2013
  1. Nicolas François

    Fix response.addString

    nfrancois authored
Commits on Sep 17, 2013
  1. Sam

    Allow for custom builds to be downloadable

    selkhateeb authored
    heroku config:set DART_SDK_URL=<url to download tar.gz file>
Commits on Oct 26, 2013
  1. Seth Ladd

    Merge pull request #19 from nfrancois/fixAddString

    sethladd authored
    Fix response.addString
  2. Seth Ladd

    Merge pull request #20 from selkhateeb/master

    sethladd authored
    Allow for custom builds to be downloaded
  3. Seth Ladd

    update sample server

    sethladd authored
  4. add a SDK built by ubuntu 10.04

    sethladd authored
  5. Seth Ladd

    don't put the SDK in just yet

    sethladd authored
  6. Seth Ladd
  7. Seth Ladd
  8. Seth Ladd
  9. Seth Ladd

    unmute curl

    sethladd authored
  10. Seth Ladd

    unmute tar

    sethladd authored
  11. Seth Ladd

    what's in app?

    sethladd authored
  12. Seth Ladd

    print before moving on

    sethladd authored
Commits on Oct 27, 2013
  1. Seth Ladd

    print before moving on

    sethladd authored
  2. Seth Ladd

    print before moving on

    sethladd authored
  3. Seth Ladd

    print before moving on

    sethladd authored
  4. Seth Ladd

    display the machine type

    sethladd authored
  5. Seth Ladd

    reformat README

    sethladd authored
  6. Seth Ladd

    print dart version

    sethladd authored
Commits on Oct 29, 2013
  1. Seth Ladd

    run build.dart with --deploy

    sethladd authored
  2. Seth Ladd

    use non-deprecated pub get

    sethladd authored
Commits on Dec 16, 2013
  1. Seth Ladd

    remove unnecessary packages

    sethladd authored
  2. Seth Ladd

    more debugging

    sethladd authored
Commits on Dec 17, 2013
  1. Seth Ladd
  2. Seth Ladd

    debug

    sethladd authored
  3. Seth Ladd

    more debug

    sethladd authored
  4. Seth Ladd
  5. Seth Ladd

    Clean up the README

    sethladd authored
Commits on Dec 22, 2013
  1. Seth Ladd
  2. Seth Ladd

    fix links

    sethladd authored
  3. Seth Ladd
  4. Seth Ladd

    Merge pull request #23 from sethladd/master

    sethladd authored
    More complex server example, better README
Commits on Jan 3, 2014
  1. Gérald Reinhart
  2. Gérald Reinhart
  3. Gérald Reinhart
  4. Gérald Reinhart
  5. Gérald Reinhart
Commits on Jan 6, 2014
  1. Gérald Reinhart

    Remove useless message

    GeReinhart authored
Commits on Jan 7, 2014
  1. merge pub build override option

    Drone Server authored
  2. real merge of pub build override option

    Drone Server authored
This page is out of date. Refresh to see the latest.
Showing with 20 additions and 3 deletions.
  1. +11 −1 README.md
  2. +9 −2 bin/compile
12 README.md
View
@@ -134,6 +134,16 @@ The sample app's `Procfile` looks like:
web: ./dart-sdk/bin/dart bin/basic_http_server.dart
```
+### Overriding the build command
+
+By default `pub build` is launched after the `pub get`, it can be useful to use
+another command: for instance `pub build --mode=debug` or
+`/app/dart-sdk/bin/dart build.dart`:
+
+```bash
+$> heroku config:set DART_BUILD_CMD="/app/dart-sdk/bin/dart build.dart"
+```
+
Learn more about
## Example
@@ -162,4 +172,4 @@ The MIT License - Copyright (c) 2012 Ilya Grigorik
[deploy]: https://devcenter.heroku.com/articles/git
[envcompile]: https://devcenter.heroku.com/articles/labs-user-env-compile
[buildforubuntu]: https://code.google.com/p/dart/wiki/BuildDartSDKOnUbuntu10_04
-[communitybuilds]: https://github.com/selkhateeb/heroku-vagrant-dart-build/releases
+[communitybuilds]: https://github.com/selkhateeb/heroku-vagrant-dart-build/releases
11 bin/compile
View
@@ -64,7 +64,15 @@ for filename in `find . -name pubspec.yaml | grep -v dart-sdk | grep -v pub-cach
message "*** Running pub build"
- /app/dart-sdk/bin/pub build
+ if [[ -z "$DART_BUILD_CMD" ]]
+ then
+ message 'Building with "pub build"'
+ /app/dart-sdk/bin/pub build
+ else
+ message "Building with \"$DART_BUILD_CMD\""
+ eval $DART_BUILD_CMD
+ fi
+
done
# I think heroku deletes all the contents of /app and replaces it with
@@ -72,4 +80,3 @@ done
# $BUILD_DIR in the first place? because we need symlinks setup correctly.
cp -R $PUB_CACHE $BUILD_DIR/pub-cache
message `ls -l $BUILD_DIR/pub-cache`
-
Something went wrong with that request. Please try again.