New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect URLs in server requests when trying to open TDF files #1168
Comments
lbergelson
added a commit
that referenced
this issue
Jul 12, 2022
lbergelson
added a commit
that referenced
this issue
Jul 12, 2022
* Correctly append ".tdf" to a url when there is a query string * Fixes #1168
@ubuntolog Thanks for the report. It will still not find the "tdf" files in most cases, of course, because not many use this option, but at least it won't find it for the correct reason. Its from very early IGV, if a "tdf" is discovered it uses it for coverage data. |
jrobinso
pushed a commit
that referenced
this issue
Jul 13, 2022
* Fix searching for TDF file when url has a query string * Correctly append ".tdf" to a url when there is a query string * Fixes #1168
jrobinso
pushed a commit
that referenced
this issue
Aug 11, 2022
* Fix searching for TDF file when url has a query string * Correctly append ".tdf" to a url when there is a query string * Fixes #1168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello everyone,
we have our own server that requires a secure token to access a file. URLs look roughly like that:
https://ourserver.com/filename.bam?token=some_text
When IGV tries to access the files from our server, it looks for index files at the same location. E.g. for BAM files it will add BAI extention to the filename and the URL will look like that:
https://ourserver.com/filename.bam.bai?token=some_text
I have been checking the server logs recently and found some failed attempts from IGV to access TDF files: it was not able to pass the token check. I did some debugging and found out that for TDF files IGV overwrites the URLs incorrectly. It adds the TDF extension to the token, but not to the filename that proceeds the parameters. Roughly like that:
https://ourserver.com/filename.bam?token=some_texttdf
The server thinks the token is invalid and returns the corresponding error code. The issue can be reproduced with the version 2.13.1. It is by no means a critical problem. I just wanted to let you know that it exists. Could someone please look into it?
The text was updated successfully, but these errors were encountered: