Browse files

Fix length of buffer copied in __nfs4_get_acl_uncached

_copy_from_pages() used to copy data from the temporary buffer to the
user passed buffer is passed the wrong size parameter when copying
data. res.acl_len contains both the bitmap and acl lenghts while
acl_len contains the acl length after adjusting for the bitmap size.

Signed-off-by: Sachin Prabhu <>
Signed-off-by: Trond Myklebust <>
  • Loading branch information...
1 parent 250f671 commit 20e0fa98b751facf9a1101edaefbc19c82616a68 Sachin Prabhu committed with Trond Myklebust Mar 22, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 fs/nfs/nfs4proc.c
@@ -3712,7 +3712,7 @@ static ssize_t __nfs4_get_acl_uncached(struct inode *inode, void *buf, size_t bu
if (acl_len > buflen)
goto out_free;
_copy_from_pages(buf, pages, res.acl_data_offset,
- res.acl_len);
+ acl_len);
ret = acl_len;

0 comments on commit 20e0fa9

Please sign in to comment.