-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all Dependencies Listed in Readme #108
Comments
They are optional requirements for those using a Python version below 3.6 which is why they are not in the readme but still included in the requirements.txt. They are used to monkey patch a bug in Requests with Python versions under 3.6. And as they are included in the requirments.txt you should not have missed them at all, as that is what is universally used to install requirements. But besides that there are prebuilt wheels after every update, so the repo is almost always equal to the current release binary, no need to build at all unless making changes to the code :) |
This issue came up with Python 3.6.1 |
This sounds more like an issue with Homebrew's restrictive policy on dependencies and less like an issue with bandcamp-dl itself. |
The reasoning behind it is Basically, not really an issue, but would be nice to list all dependencies when making a list of dependencies, as well as optional ones if possible. |
As well as sub-dependencies. Fixes iheanyi#108
As well as sub-dependencies. Fixes #108
Not all of the requirements are included in the readme, which left me stumped for a while when it did not work after building, due to missing chardet.
The text was updated successfully, but these errors were encountered: