Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all Dependencies Listed in Readme #108

Closed
ibrokemypie opened this issue Apr 14, 2017 · 4 comments
Closed

Not all Dependencies Listed in Readme #108

ibrokemypie opened this issue Apr 14, 2017 · 4 comments

Comments

@ibrokemypie
Copy link

Not all of the requirements are included in the readme, which left me stumped for a while when it did not work after building, due to missing chardet.

@Evolution0
Copy link
Collaborator

Evolution0 commented Apr 15, 2017

They are optional requirements for those using a Python version below 3.6 which is why they are not in the readme but still included in the requirements.txt. They are used to monkey patch a bug in Requests with Python versions under 3.6.

And as they are included in the requirments.txt you should not have missed them at all, as that is what is universally used to install requirements.

But besides that there are prebuilt wheels after every update, so the repo is almost always equal to the current release binary, no need to build at all unless making changes to the code :)

@ibrokemypie
Copy link
Author

This issue came up with Python 3.6.1
Came up while putting together a homebrew formula, which requires each dep to be re-stated as resources individually, since they hate formulas doing their own dependency resolution as with pip or setup.py over there.

@Evolution0
Copy link
Collaborator

This sounds more like an issue with Homebrew's restrictive policy on dependencies and less like an issue with bandcamp-dl itself.

@ibrokemypie
Copy link
Author

ibrokemypie commented Apr 15, 2017

The reasoning behind it is

Because that circumvents our hash-checks, makes finding/fixing bugs harder, often breaks patches and disables the caching.

Basically, not really an issue, but would be nice to list all dependencies when making a list of dependencies, as well as optional ones if possible.

ibrokemypie pushed a commit to ibrokemypie/bandcamp-dl that referenced this issue Apr 15, 2017
As well as sub-dependencies.
Fixes iheanyi#108
Evolution0 pushed a commit that referenced this issue Apr 15, 2017
As well as sub-dependencies.
Fixes #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants