Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #102

Merged
merged 2 commits into from Aug 24, 2016

Conversation

Projects
None yet
3 participants
@SangeetaGulia
Copy link
Contributor

commented Aug 24, 2016

No description provided.

@coveralls

This comment has been minimized.

Copy link

commented Aug 24, 2016

Coverage Status

Coverage remained the same at 88.288% when pulling ea6ae85 on SangeetaGulia:master into aef6a41 on iheartradio:master.

README.md Outdated
@@ -129,7 +129,7 @@ GET /docs/swagger.json @controllers.swagger.ApiSpecs.specs
```
#### Step 4
Add a base swagger.yml (or swagger.json) to your resources folder. This one needs to provide all the required fields according to swagger spec
Add a base swagger.yml (or swagger.json) to your resources (i.e conf folder in the play application). This one needs to provide all the required fields according to swagger spec.

This comment has been minimized.

Copy link
@kailuowang

kailuowang Aug 24, 2016

Member

Other folders could be added as resources. Would you change i.e to for example?

@kailuowang

This comment has been minimized.

Copy link
Member

commented Aug 24, 2016

thanks for your contribution.

@SangeetaGulia

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2016

Hi Wang,

I have added a commit with the change you have proposed.

On Wed, Aug 24, 2016 at 5:46 PM, Kai(luo) Wang notifications@github.com
wrote:

thanks for your contribution.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#102 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQZlcUZoO8ryrC_Z1g7nMJYdeT3xSx6pks5qjDYwgaJpZM4Jrroz
.

Warm Regards,

Sangeeta Gulia
Software Consultant Trainee
Knoldus Software LLP

@kailuowang

This comment has been minimized.

Copy link
Member

commented Aug 24, 2016

👍 thanks again. Will merge after build green.

@coveralls

This comment has been minimized.

Copy link

commented Aug 24, 2016

Coverage Status

Coverage remained the same at 88.288% when pulling 50d5141 on SangeetaGulia:master into aef6a41 on iheartradio:master.

@kailuowang kailuowang merged commit 739b8b6 into iheartradio:master Aug 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.288%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.