Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an option to toggle screen scaling type #6282

Merged
merged 7 commits into from Dec 3, 2022
Merged

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Dec 2, 2022

With introduction of "fake" full screen mode for Windows it is visible that the picture is blurred with linear mode. To cover needs of everyone we are adding a new configuration option to choose pixelated image or blurred. By default it is linear.

relates to #5373
relates to #2238
relates to #4946

Regression from #2238

With introduction of "fake" full screen mode for Windows it is visible that the picture is blurred with linear mode. To cover needs of everyone we are adding a new configuration option to choose pixelated image or blurred. By default it is pixelated.
@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff labels Dec 2, 2022
@ihhub ihhub added this to the 1.0 milestone Dec 2, 2022
@ihhub ihhub self-assigned this Dec 2, 2022
@ihhub ihhub marked this pull request as draft December 2, 2022 12:15
@ihhub ihhub changed the title Make an option to toggle scaling Make an option to toggle screen scaling type Dec 2, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

src/engine/screen.h Show resolved Hide resolved
src/engine/screen.h Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ihhub ihhub marked this pull request as ready for review December 2, 2022 22:40
@ihhub
Copy link
Owner Author

ihhub commented Dec 3, 2022

By the way, linear scaling is slower than nearest neighbour approach due to its complexity so users want to improve performance they need to switch to nearest mode. PS Vita should use this by default.

These are general thoughts.

@ihhub ihhub merged commit 3b35e5f into master Dec 3, 2022
@ihhub ihhub deleted the screen_streching branch December 3, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants