Home screen, Adjustement of window text on first game launch (#4789) #7877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-derevenetz
added
improvement
|
I am moving this pull request to 1.0.10 release as 1.0.9 is going to be very soon and we will have to update translations for this change. |
zenseii
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Hi, @jerbear1235.
I left a few additional improvements now that I see them. The rest looks good to me.
|
Hi @jerbear1235 , please fix code style issues. |
zenseii
requested changes
Oct 15, 2023
There was a problem hiding this comment.
Hi, @jerbear1235. I left another small improvement. Please have a look.
Branikolog
approved these changes
Oct 17, 2023
|
Hello @Branikolog,
Personally, I think it's okay. |
ihhub
approved these changes
Oct 19, 2023
|
@jerbear1235 , thank you so much for your contribution to the project! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the changes:
After the changes:
This PR modifies existing text and requires translations.
close #4789