Removing empty files from code base #4

Closed
ghost opened this Issue Apr 21, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Apr 21, 2015

Hallo Herr Hofmann,

im Verzeichnis admin/config sind folgende Dateien mit 0 Bytes:

adminlog.php
config.inc.php
entitylog.php
lockfile.txt

Ich bitte Sie diese ab dem nächsten Update raus zu nehmen. Wenn man das volle Verzeichnis runterlädt und aufspielt werden die vorhandenen Dateien überschrieben, was bei der config.inc.php fatal ist, wenn man kein Update gemacht hat. Das Programm OurWebFTP auf meinem Server mag z.B. keine 0 Byte Dateien und stoppt spätestens bei der lockfile.txt. So sind Sicherungen des aktuellen Systems auch nur mit unnötigen Eingriffen möglich.

Das Update-Verzeichnis sollte auch nur die Dateien enthalten, die geändert wurden. Das augenblickliche Update enthält sehr viele Dateien, welche nicht geändert wurden. So kann man nicht sehen, welche geändert sind. Spielt man nun das Update auf, so werden evt. auch eigene Änderungen an anderen Dateien überschrieben.

Zum einfacheren Handling bitte ich sie dies zu berücksichtigen.

Rolf Joseph / ErdemCan

@ihofmann ihofmann changed the title from Anregung to Removing empty files from code base Apr 21, 2015

@ihofmann

This comment has been minimized.

Show comment
Hide comment
@ihofmann

ihofmann Apr 21, 2015

Owner

An English summary for interested developers:

It appears that some FTP clients cannot handle empty files (see list of files in issue description).
Suggestion:

  • Add some content to lockfile.txt, e.g. purpose of file (shall prevent concurrent job executions).
  • Use new writable folder for creating and writing remaining files and add folder content to .gitignore. Make sure the new folder is mentioned at the installation manual and in the installation routine.

Feel free to contribute the code. :)

Owner

ihofmann commented Apr 21, 2015

An English summary for interested developers:

It appears that some FTP clients cannot handle empty files (see list of files in issue description).
Suggestion:

  • Add some content to lockfile.txt, e.g. purpose of file (shall prevent concurrent job executions).
  • Use new writable folder for creating and writing remaining files and add folder content to .gitignore. Make sure the new folder is mentioned at the installation manual and in the installation routine.

Feel free to contribute the code. :)

@ihofmann ihofmann self-assigned this Jun 21, 2015

ihofmann added a commit that referenced this issue Jun 21, 2015

Merge pull request #9 from ihofmann/remove-generated-files-from-source
Removed generated files from source resolving #4.
@ihofmann

This comment has been minimized.

Show comment
Hide comment
@ihofmann

ihofmann Jun 21, 2015

Owner

Resolved as suggested. The generated files were moved to /generated. The update routine will automatically move the files.

Owner

ihofmann commented Jun 21, 2015

Resolved as suggested. The generated files were moved to /generated. The update routine will automatically move the files.

@ihofmann ihofmann closed this Jun 21, 2015

@Requiao Requiao referenced this issue Nov 16, 2016

Closed

Job error #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment