Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On initial load KIS_UISoundPlayer trhows errors #129

Closed
ihsoft opened this issue Apr 30, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@ihsoft
Copy link
Owner

commented Apr 30, 2016

[LOG 04:36:41.988] AddonLoader: Instantiating addon 'KIS_UISoundPlayer' from assembly 'KIS'
[LOG 04:36:41.988] Loading UI sounds for KIS...
[LOG 04:36:41.989] Loading clip: KIS/Sounds/bipwrong
[ERR 04:36:41.989] Cannot locate clip: KIS/Sounds/bipwrong

[LOG 04:36:41.990] Loading clip: KIS/Sounds/click
[ERR 04:36:41.990] Cannot locate clip: KIS/Sounds/click

[LOG 04:36:41.990] Loading clip: KIS/Sounds/attachScrewdriver
[ERR 04:36:41.991] Cannot locate clip: KIS/Sounds/attachScrewdriver

It works fine after that. Looks like sounds initialization is done at the wrong moment.

@ihsoft ihsoft self-assigned this Apr 30, 2016

@ihsoft ihsoft added the bug label Apr 30, 2016

@Uzef-Sahil

This comment has been minimized.

Copy link

commented Oct 25, 2016

Attempt to check the sound file in the game based before its load in there. Need review attribute [KSPAddon(KSPAddon.Startup.EveryScene, false /once/)] on line 13, file "KIS_UISoundPlayer.cs".
I have changed it to [KSPAddon(KSPAddon.Startup.MainMenu, true)]. After that it works fine.

@ihsoft ihsoft added the duplicate label Oct 25, 2016

@ihsoft ihsoft closed this Oct 25, 2016

@ihsoft ihsoft reopened this Oct 25, 2016

@ihsoft ihsoft removed the duplicate label Oct 25, 2016

@ihsoft

This comment has been minimized.

Copy link
Owner Author

commented Oct 25, 2016

Thanks for the suggestion. In fact, this whole class is to be deprecated in favor of https://github.com/ihsoft/KSPDev/blob/master/Sources/Utils/GUIUtils/UISoundPlayer.cs.

@ihsoft ihsoft closed this in af4022b Nov 20, 2016

@ihsoft ihsoft added this to the 1.3.1 milestone Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.