Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe operator #41

Closed
mhesselbarth opened this issue Mar 14, 2023 · 2 comments
Closed

Pipe operator #41

mhesselbarth opened this issue Mar 14, 2023 · 2 comments

Comments

@mhesselbarth
Copy link
Collaborator

Currently both pipe operators are used (%>%, |>). I would suggest to either

  1. Remove pipes completely
  2. Stick to one (probably magrittr to not have to rely on R > 4.0)

Thoughts?

@Martin-Jung
Copy link
Collaborator

Yes, this was added at a time where R did not have a separate pipe. Can be removed, but needs to be checked that the pipe is not accidentally used somewhere

@Martin-Jung
Copy link
Collaborator

magrittr dependency removed in 61dcd12

Martin-Jung added a commit that referenced this issue Jun 1, 2023
* Starting to work on warnings fixing dependencies and global vars (still some stuff to deal)

* Removal of magrittr #41 and checks for deps. in actions

* Removal of cmdstanr as not on CRAN...

* Update CITATION.cff

* Fix check (#42)

* Install extra-packages in setup-r-deps step

* Fix cmethod consistency

* Linewidth examples (usage still issue but not sure how to break)

* Starting to fix some deps warnings (still some left)

* Forgot cmdstanr not on CRAN

* Fix check (#43)

* Install extra-packages in setup-r-deps step

* Fix cmethod consistency

* Linewidth examples (usage still issue but not sure how to break)

* Starting to fix some deps warnings (still some left)

* Typo in gh-actions

* Trying to fix call to require in write_output. Its not beautiful, but working...I think...

* Remove calls to require()

* Remove not need importFrom and collect them in ibis.iSDM-package.R

* Some smaller cosmetic changes

* No need to specific Namespace for functions from this package

* Remove purrr

* Small fixes to docs, split hyperparameter search and feature selection in `train`. Added Boruta

* Small bug fix introduced with last commit [no-ci]

* Small bug fix introduced with last commit [no-ci]

* Update of citation and prep for release version 0.0.3

* Url fix

* url fix attempt nr 3

* url fix attempt nr 4

---------

Co-authored-by: mhesselbarth <mhk.hesselbarth@gmail.com>
Co-authored-by: Martin-Jung <Martin-Jung@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants