New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twitter gem #138

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@KitaitiMakoto
Member

KitaitiMakoto commented Dec 17, 2013

No description provided.

@banyan

This comment has been minimized.

Member

banyan commented Dec 17, 2013

  config.access_token        = "YOUR_ACCESS_TOKEN"
  config.access_token_secret = "YOUR_ACCESS_SECRET"

The key name is also changed 😲

@@ -1,7 +1,7 @@
require 'twitter'
if Rails.env.production?
Twitter.configure do |config|
Twitter::REST::Client.new do |config|

This comment has been minimized.

@banyan

banyan Dec 17, 2013

Member

I guess it doesn't work since

Global configuration has been removed, as it was not threadsafe. Instead, you can configure a Twitter::REST::Client by passing it a block when it's initialized.

Using global variable such as

$twitter_client = Twitter::REST::Client.new

or we need to initialize in app/models/twtitter.rb, the latter is better 🙇

@coveralls

This comment has been minimized.

coveralls commented Dec 17, 2013

Coverage Status

Changes Unknown when pulling e1300c9 on update-twitter-gem into * on master*.

@KitaitiMakoto

This comment has been minimized.

Member

KitaitiMakoto commented Dec 17, 2013

decided to use yet-another-update-twitter-gem branch and will close this branch.

@KitaitiMakoto KitaitiMakoto deleted the update-twitter-gem branch Dec 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment