Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Us Added & Scroll bar fixed according to theme #5

Merged
merged 5 commits into from Oct 5, 2019

Conversation

@pAditya198
Copy link
Contributor

commented Oct 3, 2019

About Page added

Screenshot (163)

Screenshot (164)

Copy link
Member

left a comment

I think about us and CoC should be accessible without login.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Okay I'll make it so.

@aashutoshrathi

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Also the UI is too plain even for a doc.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

I think about us and CoC should be accessible without login.

But initially when the user visits login page appears, so where am I going to place the about page.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

UI for the page is changed

Screenshot (165)

Screenshot (166)

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

I've not yet made about us page accessible without login.
I think it will be better to keep it this way , adding about us in login page will not look good.

Copy link
Member

left a comment

About US -> About Us
and Remove colons from Venue and Time

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Screenshot (167)

@Monal5031

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

Screenshot (168)

@anshumanv done with the mark and the page please review, @aashutoshrathi .

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

Screenshot (169)

Copy link
Member

left a comment

Great, thanks for picking this. Several improvements are possible and I'll fix them, got to explore ng a little.

@anshumanv anshumanv merged commit e2c434f into iiitv:master Oct 5, 2019
@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

@anshumanv please also suggest improvements that could've been done from my side😅?

@anshumanv

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

It's great work overall. 👍

@anshumanv please also suggest improvements that could've been done from my side😅?

Never used angular but I feel(correct me if I'm wrong) we don't need controllers nor resolvers since it's a simple static page. Also we need about's state outside of app state since we need unauthenticated access. And some formatting changes here and there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.