New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romanian translation #2227

Merged
merged 9 commits into from Jan 24, 2019

Conversation

3 participants
@sfDuhNinja
Copy link
Contributor

sfDuhNinja commented Jan 16, 2019

  • This change has been discussed with the author.
  • It implements / fixes issue #.

Description:
This is the Romanian translation. It is 90% done. I will update it as soon as possible in order to be complete.

@sfDuhNinja

This comment has been minimized.

Copy link
Contributor Author

sfDuhNinja commented Jan 16, 2019

I would like you to accept my pull request in order to update my fork.

@alejx

This comment has been minimized.

Copy link
Member

alejx commented Jan 17, 2019

It is 90% done.

What's the remaining 10%? We should really resolve it here rather than after merging.

@saagarjha

This comment has been minimized.

Copy link
Member

saagarjha commented Jan 17, 2019

(I had written this six hours ago, but realized I never posted it, so here it is)

Is there something specific blocking you from amending your commit?

@alejx

This comment has been minimized.

Copy link
Member

alejx commented Jan 17, 2019

Ref #2054

@sfDuhNinja

This comment has been minimized.

Copy link
Contributor Author

sfDuhNinja commented Jan 17, 2019

I was having some problems with my Github app, not pushing to my repo. Now it's working. I will complete the translation today.

@sfDuhNinja sfDuhNinja closed this Jan 17, 2019

@sfDuhNinja sfDuhNinja reopened this Jan 17, 2019

@alejx

This comment has been minimized.

Copy link
Member

alejx commented Jan 18, 2019

It seems you did not push anything new to this PR. Do you need any assistance?

@alejx

This comment has been minimized.

Copy link
Member

alejx commented Jan 22, 2019

Forgot to mention that iina.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist, iina/Base.lproj/.Rapp.history and changes in iina/Base.lproj/InspectorWindowController.xib should also be reverted. Sorry about the late reply but I was busy travelling these days.

sfDuhNinja and others added some commits Jan 23, 2019

reverted the rest of the files
I changed iina.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist and iina/Base.lproj/InspectorWindowController.xib
iina/Base.lproj/.Rapp.history appears to be the same
formatting2
deleted some blank spaces
@alejx

alejx approved these changes Jan 24, 2019

@alejx alejx merged commit 575960b into iina:develop Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sfDuhNinja sfDuhNinja deleted the sfDuhNinja:iina_ro-RO branch Jan 24, 2019

@sfDuhNinja sfDuhNinja restored the sfDuhNinja:iina_ro-RO branch Jan 24, 2019

@sfDuhNinja

This comment has been minimized.

Copy link
Contributor Author

sfDuhNinja commented Jan 24, 2019

I forgot to keep the English version of the GPLv3 statement and I have just added it. Should I create a new pull request?

@alejx

This comment has been minimized.

Copy link
Member

alejx commented Jan 24, 2019

@sfDuhNinja Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment