New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization Hindi India #2254

Merged
merged 10 commits into from Jan 31, 2019

Conversation

2 participants
@SensehacK
Copy link
Contributor

SensehacK commented Jan 26, 2019

  • This change has been discussed with the author.
  • It implements / fixes issue #2054

Description:

Have added Localization Translation support for Hindi Language - India.

SensehacK added some commits Jan 23, 2019

Hindi Localization Changes
UIView Changed :
1. Initial window controller
2. MiniPlayer Window
3. Open URL Window
4. History Window
5. Crop settings Window
6. Added Translator details
7. InfoPlist License
Hindi Localization - Phase 2
UIView Changed :
1. Main Menu
2. Localizable / Main Window
3. Inspector Window
4. Preference / OSC toolbar
5. Quick settings Window
6. Subtitles / Key Record / Font Picker
7. History / Free selecting
8. Playlist VC / Utils VC
Hindi Localization - Phase 3
UIView Changed & Files :
1. Pref General/ Control  SubView VC
2. Pref Codec / KeyBinding VC
3. Pref Network / UI  VC
4. Contribution RTF
5. Filter Window Controller
6. About Window Controller
7. Key Binding
@SensehacK

This comment has been minimized.

Copy link
Contributor Author

SensehacK commented Jan 26, 2019

Resolved Conflicts with two files :)

@SensehacK

This comment has been minimized.

Copy link
Contributor Author

SensehacK commented Jan 26, 2019

I didn't know what to upload with IINA Translation utility, But I'm attaching this screenshot with the utility.
Please let me know If I'm missing anything. Happy to contribute more :)

screenshot 2019-01-26 at 12 43 59

Show resolved Hide resolved iina/hi.lproj/PrefGeneralViewController.strings Outdated
Show resolved Hide resolved iina/hi.lproj/PrefSubViewController.strings Outdated
Show resolved Hide resolved iina/hi.lproj/PrefNetworkViewController.strings Outdated

SensehacK added some commits Jan 31, 2019

Resolve Hindi Localization Changes.
Also added proper spacing towards my last merge conflicts.
@SensehacK
Copy link
Contributor Author

SensehacK left a comment

All changes have been commited & also resolved merge conflicts with Brazil - Portuguese.

Added proper spacing towards my last merge conflicts
For some reason Github resolve conflicts don't take proper indentation when edited/resolved text on Web.
@@ -2037,7 +2037,7 @@
sk,
sv,
ro,
hi,
hi,

This comment has been minimized.

@alejx

alejx Jan 31, 2019

Member

What did you do in this commit? It seems not right viewing on GitHub.

This comment has been minimized.

@SensehacK

SensehacK Jan 31, 2019

Author Contributor

When I pressed resolve conflict issues on Github Web, It doesn't indents properly according to Xcode indentation. So I had to take pull on my local machine & add proper indentation in "project.pbxproj" file using Visual Studio Code editor.

This comment has been minimized.

@alejx

alejx Jan 31, 2019

Member

But still, it looks not correct now. Can you try to fix that again?

This comment has been minimized.

@SensehacK

SensehacK Jan 31, 2019

Author Contributor

So on github Web it shows different indentation, should I just revert my indentation changes ?

This comment has been minimized.

@SensehacK

SensehacK Jan 31, 2019

Author Contributor

Attaching a screenshot :)
On github Desktop & Xcode / VS Code looks fine.
screenshot 2019-01-31 at 20 45 07

This comment has been minimized.

@alejx

alejx Jan 31, 2019

Member

Your previous version used all spaces; current version used mixed spaces and tabs. Only tabs is used in other lines.

This comment has been minimized.

@SensehacK

SensehacK Jan 31, 2019

Author Contributor

Please suggest me what should I use to check whether the indentation is correct.

Now using VS Code for deleting whitespace / Tabs & then pressing enter.

screenshot 2019-01-31 at 21 05 37

@alejx alejx merged commit 361f796 into iina:develop Jan 31, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment