New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hindi localization v1.0.2 #2299

Merged
merged 2 commits into from Feb 11, 2019

Conversation

2 participants
@SensehacK
Copy link
Contributor

SensehacK commented Feb 11, 2019

  • This change has been discussed with the author.
  • It implements / fixes issue #2285.

Description:

So I created a pull request to get the latest updates of the develop branch.

SensehacK added some commits Feb 11, 2019

Merge pull request #1 from iina/develop
Latest pull Sync.
@@ -44,7 +44,7 @@ class Regex {
let ignorePlaceHolderTitle = true
let checkRedundantKey = false

let languages = ["de", "fr", "it", "ja", "ko", "pl", "zh-Hans", "zh-Hant", "ru", "tr", "es", "uk", "nl", "sk", "da", "sv", "ro", "pt-BR", "cs"]
let languages = ["de", "fr", "it", "ja", "ko", "pl", "zh-Hans", "zh-Hant", "ru", "tr", "es", "uk", "nl", "sk", "da", "sv", "ro", "pt-BR", "cs", "hi"]

This comment has been minimized.

@SensehacK

SensehacK Feb 11, 2019

Author Contributor

Didn't add "hi" hindi keyword earlier.

@SensehacK SensehacK referenced this pull request Feb 11, 2019

Closed

Localization Hindi India #2297

1 of 2 tasks complete
@alejx

This comment has been minimized.

Copy link
Member

alejx commented Feb 11, 2019

It seems you forgot new strings in PrefUIViewController.xib.
Never mind, you have already done that.

@SensehacK

This comment has been minimized.

Copy link
Contributor Author

SensehacK commented Feb 11, 2019

It seems you forgot new strings in PrefUIViewController.xib.
Never mind, you have already done that.

Yep I just crosschecked again @alejx , Already done. :)

@alejx alejx self-assigned this Feb 11, 2019

@alejx alejx merged commit 97f522d into iina:develop Feb 11, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@SensehacK SensehacK deleted the SensehacK:hindi-localization-v1.0.2 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment