Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search bar to filter key bindings #2337

Merged
merged 4 commits into from Mar 30, 2019

Conversation

2 participants
@alejx
Copy link
Member

commented Feb 28, 2019

Description:
This PR rewrite the data source of Key binding table view (in order to utilize the bindings between NSSearchBar and NSArrayController).

Ref: #2241

@alejx alejx requested a review from lhc70000 Feb 28, 2019

@alejx alejx force-pushed the keybinding-searchbar branch from 582c672 to f1e5cc1 Feb 28, 2019

@alejx alejx force-pushed the keybinding-searchbar branch from f1e5cc1 to 8435687 Mar 30, 2019

@@ -765,6 +767,7 @@ struct Preference {
.useMpvOsd: false,
.enableLogging: false,
.logLevel: Logger.Level.debug.rawValue,
.displayRawValue: false,

This comment has been minimized.

Copy link
@lhc70000

lhc70000 Mar 30, 2019

Member

Should be more precise, like displayKeyBindingRawValues

@lhc70000 lhc70000 merged commit 532892f into develop Mar 30, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@lhc70000 lhc70000 deleted the keybinding-searchbar branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.