Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Swift 5 #2378

Merged
merged 2 commits into from May 21, 2019

Conversation

3 participants
@saagarjha
Copy link
Member

commented Mar 26, 2019

  • This change has been discussed with the author.
  • It implements / fixes issue #.

Since Xcode 10.2 dropped yesterday, I think we should merge this in as soon as we get this looked over again. I think there are some UnsafePointer APIs left that I should look at; other than that it's mostly boilerplate.

@saagarjha

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

(We will also need a new libmpv compiled without Swift, FWIW)

@saagarjha saagarjha force-pushed the swift-5 branch from 9b7ac05 to b5b15f1 Mar 26, 2019

@Noctem

This comment has been minimized.

Copy link

commented Mar 28, 2019

Seems to be working smoothly with the same build tweaks that I normally make (0fe559e) and these formulae for ffmpeg and mpv.

I still intermittently experience hangs/crashes when a video is launched directly to fullscreen (probably #2221), but I've been experiencing that for months. The conditions for triggering it don't seem to be entirely consistent however.

Show resolved Hide resolved Podfile Outdated

@saagarjha saagarjha force-pushed the swift-5 branch from b5b15f1 to 4ce29b6 Mar 30, 2019

@saagarjha

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

Figured out how to build the libraries myself and double-checked that IINA at least runs. Moving out of draft status and requesting review.

(I would appreciate discussion around the use of withUnsafeBytes: what are the semantics of what we're trying to do here?)

@saagarjha saagarjha marked this pull request as ready for review Mar 30, 2019

@saagarjha saagarjha force-pushed the swift-5 branch 2 times, most recently from 6ac3f7d to 72cf93a Apr 5, 2019

@saagarjha saagarjha force-pushed the swift-5 branch from 72cf93a to f0bcd12 May 6, 2019

@alejx alejx merged commit 0595aba into develop May 21, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.