Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Polish translations #2500

Merged

Conversation

@bdolewski
Copy link
Contributor

commented Jun 15, 2019

  • This change has been discussed with the author.
  • It implements / fixes issue #.

Updated translations for Polish language using latest iina-translation-utility.
No manual changes other than results of iina-translation-utility

Bartosz Dolewski
@bdolewski

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Hi @alejx
This PR should be merged after #2358 (I'll fix all conflicts if any).
Could you please add label for translations as well?

@igorwojda
Copy link
Contributor

left a comment

These translations look good.

@alejx alejx changed the base branch from develop to polish-update Jul 22, 2019

@alejx

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@bdolewski Really sorry for the huge delay. I've merged @igorwojda 's pr into yours. Feel free to push commits if you see anything wrong. If all good to you I'll merge it into develop.

@bdolewski

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

@alejx I'll check everything and and let you know.

@bdolewski

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

Okay, I've re-checked my PR after @alejx merge with @igorwojda's PR. Looks good to me, I'll submit more patches to Polish localisation soon :)

@alejx alejx merged commit fc0e008 into iina:polish-update Jul 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alejx

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

[!][pl] Key "l2M-TH-eCt.ibShadowedToolTip" doesn't exist in PrefKeyBindingViewController
[!][pl] Key "pNF-Fw-QtW.title" doesn't exist in PrefSubViewController
[!][pl] Key "hEk-7E-10r.title" doesn't exist in PrefSubViewController
[!][pl] Key "G8w-J7-1q1.title" doesn't exist in PrefUIViewController
[!][pl] Key "HMc-Oy-hBR.label" doesn't exist in AboutWindowController
[!][pl] Key "U9l-uR-i7g.title" doesn't exist in AboutWindowController
[!][pl] Key "KfL-r7-Uav.title" doesn't exist in PrefGeneralViewController
[!][pl] Key "Kt3-me-43R.placeholderString" doesn't exist in FontPickerWindowController
[!][pl] Key "aot-6J-Jp7.title" doesn't exist in MiniPlayerWindowController
[!][pl] Key "menu.exit_fullscreen" doesn't exist in Localizable
[!][pl] Key "Tue-O7-cei.title" doesn't exist in MainMenu
[!][pl] Key "7Bn-Mp-EvJ.title" doesn't exist in MainMenu
[!][pl] Key "7rG-Yq-EYG.title" doesn't exist in MainMenu
[!][pl] Key "dBM-BU-5xS.title" doesn't exist in MainMenu
[!][pl] Key "zpw-Ac-F3M.title" doesn't exist in MainMenu
[!][pl] Key "iQf-Gb-IuO.title" doesn't exist in PrefCodecViewController
[!][pl] Key "xhd-tg-xTO.title" doesn't exist in KeyRecordViewController

I've enabled pl localization for the app, but there're still some missing strings. Please add these missing strings and make a PR against iina:polish-update, thanks!

@bdolewski

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Cool! I tried to checkout into polish-update branch inside my fork but this branch is not visible by any means. Do you know maybe what could be causing this?

~/Development/GitHub/iina-bartek(feature/update-polish-translations*) » git branch -r                                                                                                                                                      bartoszdolewski@DrumSoft-MacBook-Pro

  origin/HEAD -> origin/develop
  origin/NSButton-block-main
  origin/accepts-first-mouse
  origin/custom-fullscreen
  origin/develop
  origin/feature/update-polish-translations
  origin/ff-refactor
  origin/fix-1720
  origin/master
  origin/plugin-system
  origin/quicklook
  origin/release/1.0.0
  origin/release/1.0.1
  origin/release/1.0.2
  origin/release/1.0.4
  origin/swift-5
  origin/switch-to-music-mode-on-pip
  origin/termination_logic
  origin/video-filter 

alejx added a commit that referenced this pull request Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.