Fix Video QuickSettings view #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constraints in the Video Quicksettings view were misconfigured. The "Aspect Ratio" section (and everything below it) had their vertical positioning constrained to the "Table View" instead of the table's respective "Scroll View". This means that if a video has more than 3 video tracks or so, Aspect ratio and everything below it are pushed down to be aligned with the bottom of the video track list, which are hidden under the limit of the scroll view. This fixes that.
|
Thank you very much! |
0111b
pushed a commit
to 0111b/iina
that referenced
this pull request
Nov 7, 2020
Constraints in the Video Quicksettings view were misconfigured. The "Aspect Ratio" section (and everything below it) had their vertical positioning constrained to the "Table View" instead of the table's respective "Scroll View". This means that if a video has more than 3 video tracks or so, Aspect ratio and everything below it are pushed down to be aligned with the bottom of the video track list, which are hidden under the limit of the scroll view. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Constraints in the Video Quicksettings view were misconfigured. The "Aspect Ratio" section (and everything below it) had their vertical positioning constrained to the "Table View" instead of the table's respective "Scroll View". This means that if a video has more than 3 video tracks or so, Aspect ratio and everything below it are pushed down to be aligned with the bottom of the video track list, no matter how long that list is and even if everything after the third track is hidden by the limit of the scroll view.
This issue is understandably hard to come by since most media files only have 1 video track (if any, in case of audio only tracks). I happen to configure youtube-dl to show all tracks available giving me the ability to choose between them at runtime, switching resolutions, codecs, and bitrates around without having to restart the video with different ytdl format settings. This is how I encountered this issue. This commit fixes it. See screenshot below.
Here is two screenshots combined in one picture. Taken while playing a video that has 20 video tracks. Left is current behavior, right is with the proposed fix.
Notice on the left sided screen how the Y position of the Aspect Ration section is positioned right where the entire list of video tracks is supposed to end (i.e after 20 entries). Although the latter are hidden by the limits of the scroll view. One the right however, everything is lined up how it's supposed to be.