Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some @import url's in <style> section of html are not rewritten #131

Closed
ldko opened this issue Jun 18, 2014 · 2 comments · Fixed by internetarchive/wayback#29 or #208
Closed

some @import url's in <style> section of html are not rewritten #131

ldko opened this issue Jun 18, 2014 · 2 comments · Fixed by internetarchive/wayback#29 or #208

Comments

@ldko
Copy link
Member

ldko commented Jun 18, 2014

This was an issue in old Wayback that was at one point fixed (https://webarchive.jira.com/browse/ACC-16), but it seems like it could be the case that some @import URLs are not being rewritten in openwayback.

For example in the html source of:
http://cybercemetery.unt.edu/archive/lincoln/20100512140738/http://www.abrahamlincoln200.org/

the URLs are not being rewritten here:

<style type="text/css">
<!-- @import url(css/screen.css); -->
<!-- @import url(css/puppet-commencement.css); -->
</style>

and in:
http://webarchive.library.unt.edu/unt/eotcd/20131004144728/http://research.library.unt.edu/eotcd/wiki/Main_Page

the URLs are not being rewritten here:

<style type="text/css" media="screen, projection">/*<![CDATA[*/
            @import "/eotcd/w/skins/common/shared.css?303";
            @import "/eotcd/w/skins/thowikiskin/main.css?303";
        /*]]>*/</style>
@ldko
Copy link
Member Author

ldko commented Oct 16, 2014

Fixed. internetarchive#29

@ldko
Copy link
Member Author

ldko commented Nov 3, 2014

internetarchive#29 fixed the @import URLs in the CDATA section as given in one of the examples, but in the other example, without a CDATA section, the @import url() is not being rewritten:

The unfixed example is in the html source of:
http://cybercemetery.unt.edu/archive/lincoln/20100512140738/http://www.abrahamlincoln200.org/

the URLs are not being rewritten here:

<style type="text/css">
<!-- @import url(css/screen.css); -->
<!-- @import url(css/puppet-commencement.css); -->
</style>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants