Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQUEST] Sanitation Specs #64

Closed
thealphadollar opened this issue Aug 14, 2019 · 2 comments

Comments

@thealphadollar
Copy link
Collaborator

commented Aug 14, 2019

Please Describe The Problem To Be Solved
The code currently is very poor in terms of code quality. Below are the steps that need to be taken to improve upon the same.

  • Remove the pre-commit hooks installed by @rakaar in #11 Have a look at the files and remove the unnecessary ones.

  • Create a sanity.sh file with the following contents.

dodgy
isort -rc --atomic ./
pydocstyle --config=./.pydocstylerc
pycodestyle ./ --config=./.pycodestylerc

Please install all the above tools as well if any of them as missing. Remove my-py.

@issue-label-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@thealphadollar

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

fixed via #62

Brahma Ek automation moved this from To do to Done Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.